-
Notifications
You must be signed in to change notification settings - Fork 673
feat: add AriaStatus and AriaAlert to stable entrypoint #8300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joshblack
wants to merge
6
commits into
main
Choose a base branch
from
feat/add-aria-announce-helpers-to-stable
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8ce3861
feat: add AriaStatus and AriaAlert to stable entrypoint
joshblack c2a133d
chore: add changeset
joshblack c9751ee
chore: add stories key to component docs
joshblack c426b0c
Merge branch 'main' into feat/add-aria-announce-helpers-to-stable
joshblack 62af779
Potential fix for pull request finding
joshblack ec481d0
Add default As type param to AriaAlertProps
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@primer/react': minor | ||
| --- | ||
|
|
||
| Promote AriaStatus and AriaAlert from experimental to stable | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| 'use client' | ||
|
|
||
| export {default as theme, type ThemeColorPaths, type ThemeShadowPaths} from './theme' | ||
| export {AriaStatus, AriaAlert} from './live-region' | ||
| export type {AriaStatusProps, AriaAlertProps} from './live-region' | ||
|
Comment on lines
+4
to
+5
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in ec481d0 — |
||
| export {default as BaseStyles} from './BaseStyles' | ||
| export type {BaseStylesProps} from './BaseStyles' | ||
| export {default as ThemeProvider} from './ThemeProvider' | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| { | ||
| "id": "aria-alert", | ||
| "name": "AriaAlert", | ||
| "status": "alpha", | ||
| "a11yReviewed": false, | ||
| "importPath": "@primer/react", | ||
| "stories": [], | ||
| "props": [ | ||
| { | ||
| "name": "announceOnShow", | ||
| "type": "boolean", | ||
| "description": "Specify if the content of the element should be announced when this component is rendered and is not hidden", | ||
| "defaultValue": "true" | ||
| } | ||
| }, | ||
| { | ||
| "name": "hidden", | ||
| "type": "boolean", | ||
| "description": "Specify if the element is hidden", | ||
| "defaultValue": "false" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| { | ||
| "id": "aria-status", | ||
| "name": "AriaStatus", | ||
| "status": "alpha", | ||
| "a11yReviewed": false, | ||
| "importPath": "@primer/react", | ||
| "stories": [], | ||
| "props": [ | ||
| { | ||
| "name": "announceOnShow", | ||
| "type": "boolean", | ||
| "description": "Specify if the content of the element should be announced when this component is rendered and is not hidden", | ||
| "defaultValue": "false" | ||
| }, | ||
| { | ||
| "name": "hidden", | ||
| "type": "boolean", | ||
| "description": "Specify if the element is hidden", | ||
| "defaultValue": "false" | ||
| }, | ||
| { | ||
| "name": "delayMs", | ||
| "type": "number", | ||
| "description": "Provide a delay in milliseconds before the announcement is made" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.