feat: Scope Helm redeploy on drift to only the chart that drifted - #1915
Merged
Conversation
gianlucam76
force-pushed
the
multiple-charts
branch
from
August 13, 2026 17:22
319ef4b to
4eef789
Compare
When a ClusterProfile deploys multiple Helm charts with syncMode ContinuousWithDriftDetection, drift on a single resource used to mark the entire Helm feature for redeploy, and unconditionally upgraded every chart in the profile regardless of whether it had drifted or even changed. HelmChartSummary gains NeedsRedeploy, set per chart when drift is detected, and shouldUpgrade now checks it before falling through to the existing value/patches/version diff, instead of always returning true for drift-detection mode. A chart neither drifted nor changed is left alone. Falls back to marking every chart when no chart-scoped info is available so drift is never silently missed, just not always scoped.
gianlucam76
force-pushed
the
multiple-charts
branch
from
August 14, 2026 05:35
4eef789 to
5877e05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a ClusterProfile deploys multiple Helm charts with syncMode ContinuousWithDriftDetection, drift on a single resource used to mark the entire Helm feature for redeploy, and unconditionally upgraded every chart in the profile regardless of whether it had drifted or even changed. HelmChartSummary gains NeedsRedeploy, set per chart when drift is detected, and shouldUpgrade now checks it before falling through to the existing value/patches/version diff, instead of always returning true for drift-detection mode. A chart neither drifted nor changed is left alone. Falls back to marking every chart when no chart-scoped info is available so drift is never silently missed, just not always scoped.