Skip to content

Reflow the Runbook's Coverage Paragraph to One Width - #1713

Open
ptr727 wants to merge 1 commit into
developfrom
feature/reflow-runbook-coverage-paragraph
Open

ptr727 wants to merge 1 commit into
developfrom
feature/reflow-runbook-coverage-paragraph

Conversation

@ptr727

@ptr727 ptr727 commented Sep 20, 2026

Copy link
Copy Markdown
Owner

Answers the one finding on the develop -> main promotion #1712, which cannot take the fix on its own head.

The finding

The sentence "Re-run the loop after every fix push" was split across two lines, with push. opening a line under an eight-column finding. The break predates #1709, but #1709 rewrapped every line of that paragraph around it and left it, which is what turned the original spacing into something that reads as an accidental hard wrap.

The paragraph also ran from 87 to 124 columns where its neighbours run 91 to 99.

The change

Reflowed to one width. The result is a clean greedy wrap at column 96 and no line is an outlier.

The word sequence is unchanged, asserted rather than eyeballed. The file's split() is identical before and after, 2254 tokens on each side, and the character count is the same, one newline having become a space. Checked per paragraph as well as over the whole file, so no word crossed a paragraph boundary: 28 paragraphs before, 28 after, each comparing equal.

The reflowed range carries no link, reference definition, table, or list marker, and the one code span sits entirely within a single line. This file is intent fidelity in spec/files.json, so it is judged by meaning and never hashed, and a reflow cannot trip a verbatim comparison downstream.

Verification

Full suite green at 405 tests, ruff format, ruff check, mypy, prose_lint --diff at zero violations, repo_gate --check eol, spec/validate.py, and build_dist.py --check all pass. One local review pass, no findings.

🤖 Generated with Claude Code

The paragraph ran from 87 to 124 columns and broke "Re-run the loop after every
fix push" across two lines, leaving "push." opening a line under an eight-column
"finding." The split predates the change that rewrote this paragraph, and that
change rewrapped every line around it and left it, which is what made it read as
an accidental hard wrap rather than as the original spacing.

Reflowed to the 87 to 96 columns the neighbouring paragraphs use. The word
sequence is unchanged, asserted rather than eyeballed: the file's `split()` is
identical before and after and the character count is the same, one newline
having become a space.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings September 20, 2026 03:03
@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 0d803136-8b21-41d6-9274-1d4df528928a


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The updated paragraph remains hard-wrapped, which conflicts with the repo’s “one logical paragraph per line” Markdown convention.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Low severity

Open (1)
What changed in this PR

This PR adjusts the formatting of the “formal review with no findings” coverage paragraph in .github/copilot-instructions.md to remove an accidental-looking hard wrap and make the line wrapping consistent within that block.

Changes:

  • Reflowed the coverage paragraph so “Re-run the loop after every fix push.” is no longer split across lines.
  • Normalized the wrapping of that paragraph to a consistent target width.
File Description
.github/​copilot-instructions.md Reflows the coverage paragraph to avoid an outlier hard wrap and normalize wrapping.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines 57 to +61
A formal review with no findings is complete only when it covers the current head and full diff
coverage is stated for the change set that head has. The round covering the head states it, or the
newest round that states it at all does and the pull request changes the same set of files at
both commits, which is the only condition under which a statement carries forward. Only that
newest round is consulted, so an older round whose change set does match carries nothing. A round reporting partial coverage
of the diff blocks the merge, and so does a refusal, a coverage statement that does not reach
this head, meaning absent from every round or carried by none because the change set moved or
could not be compared, an unrecognized output shape, an unresolved thread, or a body-only
finding.
Re-run the loop after every fix
push. Never infer review completion from `mergeStateStatus: CLEAN`.
coverage is stated for the change set that head has. The round covering the head states it, or
the newest round that states it at all does and the pull request changes the same set of files
at both commits, which is the only condition under which a statement carries forward. Only that
newest round is consulted, so an older round whose change set does match carries nothing. A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants