Rename spec files as _spec.rb so they run - #1633
Conversation
|
Easiest solution is declare the types private api and remove the tests but I'm not sure that was the original intention. |
|
I recall there was a rubocop-rspec plugin that looked for these wrong filenames.
@SimonHoenscheid mind taking a look since you wrote this? |
|
This requires #1691 to be able to run tests. |
A number of spec files were named incorrectly and consequently never running. Rename them so they actually run. One test now fails as a consequence. While this should be fixed one way or the other a fix for that is outside of scope of this patch.
|
Running CI for this PR here: #1698 |
|
Acceptance test results: https://github.com/puppetlabs/puppetlabs-postgresql/actions/runs/32537000723 Mostly green acceptance tests. All acceptance-test failures in this PR's CI run match existing failures already present on main's nightly run (CentOS-7/OracleLinux-7/Scientific-7 systemd D-Bus service-start issue, Debian-13 default_privileges idempotency failure, SLES-12 provisioning timeout). None are caused by this change. Next step requires an engineering review. |
3 participants
A batch of spec files were never being executed due to having the wrong name.
Tests have all been marked pending as I expect they have never passed.
Fixing them , deleting them or updating how the module works is best handled elsewhere as not very obvious.