Remove deprecated functions and unused private function - #2766
Conversation
15d9d60 to
aae7eb7
Compare
|
@JoLo90 I think we should consider each of these removals before bundling them all into one PR. Can you open a few more issues to discuss other removals? |
RDaxini
left a comment
RDaxini
left a comment
There was a problem hiding this comment.
Added a suggestion to the whatsnew. I can do a a more technical review later.
Note for future PRs though @JoLo90, please only tick off checklist items when complete. For example, a maintainer has not added any relevant labels or milestone to this PR yet so this should not have been ticked. I will do it now (so no need to remove the tick now). This will just help us organize the work more efficiently and ensure we don't miss anything.
Thanks again for your continued contributions by the way, these are appreciated.
|
@JoLo90 do you still intend to work on this? If not, I can fork the branch and finish this off in time for the 0.16.0 release. |
|
@RDaxini sorry for the delay I will commit the changes |
542b555 to
436f5dc
Compare
…, parse_cams, get_orientation and delete decorator for deprecation for get_cams
436f5dc to
1897e4b
Compare
|
|
||
| * Removed private function :py:func:`pvlib.irradiance._liujordan`. | ||
| (:issue:`2764`, :pull:`2766`) | ||
| * Removed deprecated iotools aliases :py:func:`pvlib.iotools.parse_bsrn`, |
There was a problem hiding this comment.
| * Removed deprecated iotools aliases :py:func:`pvlib.iotools.parse_bsrn`, | |
| * Removed deprecated iotools functions :py:func:`pvlib.iotools.parse_bsrn`, |
AdamRJensen
changed the title
5 participants
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.