Skip to content

Add support for iam.schlick to ModelChain - #2832

Merged
kandersolar merged 11 commits into
pvlib:mainfrom
cbcrespo:schlick-integration
Aug 7, 2026
Merged

Add support for iam.schlick to ModelChain#2832
kandersolar merged 11 commits into
pvlib:mainfrom
cbcrespo:schlick-integration

Conversation

@cbcrespo

@cbcrespo cbcrespo commented Jul 23, 2026

Copy link
Copy Markdown
Contributor
  • Closes Add support for iam.schlick to ModelChain #2828
  • I am familiar with the contributing guidelines
  • I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Currently, all direct IAM models available in pvlib.iam are supported by ModelChain except for schlick. This PR adds support for schlick.

Comment thread pvlib/iam.py Outdated
@AdamRJensen

Copy link
Copy Markdown
Member

@cbcrespo Given Anton's comment here I think we should also add a warning to the function itself (an admonition) stating something along the lines of:

The Schlick IAM model has not been validated for PV performance modeling and is not commonly used in PV applications. Users should consider these limitations when selecting models.

@RDaxini RDaxini left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a note on pvsystem.py and the whatnsew. #2832 (comment) should also be addressed and then I think this PR is ready to go.

Comment thread pvlib/pvsystem.py Outdated
Comment thread docs/sphinx/source/whatsnew/v0.15.3.rst

@kandersolar kandersolar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some tests for the PVSystem and Array methods would be good too. There should be existing tests that you can easily hook into like you did with the ModelChain tests.

One other thing: of course we can't infer schlick from the parameters (since it takes no parameters), but I suppose a comment in the inference function along those lines would be nice. Something here indicating that schlick is omitted on purpose:

https://github.com/cbcrespo/pvlib-python/blob/4ea1a645a46f6c373897a1d0436f9e21aa517b10/pvlib/modelchain.py#L801

Comment thread docs/sphinx/source/whatsnew/v0.16.0.rst Outdated
@kandersolar

Copy link
Copy Markdown
Member

Linter failure is on lines not touched by this PR

@kandersolar
kandersolar merged commit 6382338 into pvlib:main Aug 7, 2026
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement GSoC Contributions related to Google Summer of Code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for iam.schlick to ModelChain

5 participants