Let CancelledError propagate from async execute - #3010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3009.
The async execute path caught asyncio.CancelledError and re-raised it as a ModbusIOException. Because that is a plain Exception, callers using a try/except Exception around read/write calls swallow it, so Task.cancel() no longer actually cancels a request that is waiting for a response.
Dropping the handler lets the CancelledError propagate normally, which releases the lock on the way out and cancels the task as expected. Updated the cancel scenario in the transaction test to check the task is cancelled rather than expecting the wrapped exception.