Reject out-of-range URL ports (0–65535) - #198
Open
Pitchfork-and-Torch wants to merge 2 commits into
Open
Pitchfork-and-Torch wants to merge 2 commits into
Pitchfork-and-Torch wants to merge 2 commits into
Conversation
URL.from_text() and URL() accepted ports like -1 and 65536/99999 after int() conversion. Validate the TCP/UDP port range on parse and construction so callers get URLParseError/ValueError instead of serializing illegal authorities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
URL.from_text()andURL()accepted ports outside 0–65535 (e.g.-1,65536,99999) afterint()conversion. Validate the range on parse (URLParseError) and construction (ValueError).Distinct from #192 / malformed digit strings — this is numeric range enforcement.
Test plan
URL.from_text("http://ex.com:-1")/:65536/:99999raiseURLParseErrorURL(..., port=-1)raisesValueError:8080and:65535still accepted