Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The toml-test datetime expectations currently use
parse_rfc3339, the same function used by the parser. A parsing regression can therefore change both actual and expected values without failing compliance tests.datetime,date, andtimeconstructors viafromisoformatfor the four datetime-related JSON types.Zand fractional-second precision for Python 3.9/3.10 compatibility.+05:30and-03:30).No production behavior or dependencies change. Addresses the datetime-oracle and minute-offset coverage gaps in #603; the separately mentioned
unwrap()value assertions are not included.Verification
python -m pytest -q tests— 1,060 passed.python -m pytest -q -rs tests— 1,059 passed, 1 existing skip (integer-string digit-limit test requires 3.9.14+).git diff --check— passed.mypy tomlkit testsreports the same 29 pre-existing errors in four unchanged files before and after the patch (including the toml-test generator).Tests used pytest 7.4.4, an explicit local
--basetemp, and direct pytest invocation rather than a full Poetry development install. Other platform/Python combinations have not been tested locally.Mutation checks were run in disposable copies, with the production source left unchanged:
These mutations demonstrate test sensitivity, not existing production parser bugs.
Agent Drafting Metadata