Add post-processing hook for custom token transformations - #87
Open
hedgert wants to merge 2 commits into
Open
Conversation
pquentin
reviewed
Jul 30, 2026
pquentin
left a comment
Member
There was a problem hiding this comment.
Thanks! Do you mind adding a test to clarify how this would be used?
Bug fix (after my testing focused on using the hook to override the post processor method instead of testing the default post processor Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com>
Author
|
(I think I overwrote my earlier reply with my comment about the token to tokens change - so repeating it). Re your request for an example: Thanks for the review. While putting together the test, I realised there are two possible directions:
Do you have a preference? I'm happy to take whichever approach best fits the project's direction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unasync currently provides excellent support for single-token replacements
during async-to-sync conversion.
Some transformations, however, require replacing one token with multiple
tokens or vice versa. Examples include:
Solution
This change introduces an optional post-processing hook that runs after
the existing token replacement stage.
The hook receives the token stream and allows more complex transformations
to be implemented without affecting the existing replacement mechanism.
Existing users are unaffected unless they choose to provide a
post-processor.
Motivation
This extension makes it possible to implement more sophisticated language
transformations while keeping the existing replacement system simple.