Update GeoJSON docs after the MultiPoint tooltip fix - #2282
Open
nina-mir wants to merge 1 commit into
Open
Conversation
Both pages describe GeoJsonTooltip and GeoJsonPopup as having limitations with MultiPoint and other multi-geometries, and point users at on_each_feature as the workaround. python-visualization#2263 fixed that, so the guidance now sends people to raw JavaScript for something the standard classes handle. Rewords the on_each_feature page around what it is actually for, and replaces the closing note in the popup and tooltip page with a plain pointer to the advanced guide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2263.
Both pages still describe
GeoJsonTooltipandGeoJsonPopupas having limitations with MultiPoint and other multi-geometries, and point users aton_each_featureas the workaround. That's no longer true, so the current guidance sends people to rawJavaScript for something the standard classes now handle.
Verified with a map containing all eight geometry types: tooltips render on hover and popups on click for MultiPoint and GeometryCollection, including a GeometryCollection containing a MultiPoint.
Related, not changed here:
warn_for_geometry_collections(features.py:1195) still advises reworking GeometryCollection features to MultiPolygon "for full functionality." Both tooltips and popups now work on those geometries. I left it alone since removing it means updatingtest_geojson_tooltip, which asserts the warning fires.Happy to do that here or separately if you'd like it gone.