fix: skip tests and CodeQL for doc-only changes - #1280
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe CodeQL workflow ignores documentation, Markdown, reStructuredText, and Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Tick the box to add this pull request to the merge queue (same as
|
|
One thing I need to verify but need admin access to do so: I need to look at Required checks interaction. From claude When paths-ignore causes a workflow to be skipped entirely, GitHub reports the jobs as "skipped" rather than "success." If branch protection rules require those jobs (e.g., unit, e2e, coverage) to pass before merging, doc-only PRs will be unmergeable because the required checks never run. @LalatenduMohanty can you help with this please? |
yes, we need to fix this. |
|
No required status checks are configured on main. empty lists mean no jobs are gating merges, so paths-ignore skipping workflows won't block doc-only PRs. |
|
perfect, thank you @LalatenduMohanty |
7ac0941 to
5a04afc
Compare
rd4398
left a comment
There was a problem hiding this comment.
This looks good! Thank you!
|
@mergify rebase |
🛑 The pull request rule doesn't match anymoreDetailsThis action has been cancelled. |
Add paths-ignore for docs/** to test.yaml and codeql.yaml so that doc-only PRs no longer trigger the full CI matrix (unit tests, e2e tests, CodeQL analysis). check.yaml is left unchanged since it runs the Sphinx docs build that validates proposal files. Co-Authored-By: Claude <claude@anthropic.com> Closes: python-wheel-build#1230
5a04afc to
57c8f8b
Compare
Add paths-ignore for docs/** to test.yaml and codeql.yaml so that doc-only PRs no longer trigger the full CI matrix (unit tests, e2e tests, CodeQL analysis). check.yaml is left unchanged since it runs the Sphinx docs build that validates proposal files.
Closes: #1230
Pull Request Description
What
Why