gh-121647: Define _Py_TYPEOF macro on more compilers - #121648
Merged
Merged
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
encukou
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
Member
|
Hello! Sorry for the delay in reviewing. Ideally, find a way to use Also, I'd prefer not adding the configure check. I don't see much benefit over |
Contributor
Author
|
Thanks for reviewing, I did the PR to see if it gets a better chance than #121643, however cpython has grown to requiring more patches ( On C23 |
Member
|
Thanks. |
Contributor
Author
|
Just tested 3.15 master (default and --disable-gil), in addition to #134070 these are enough for slimcc to pass all tests (sans test_gdb, probably caused by lacking DWARF info). diff --git a/Include/internal/pycore_debug_offsets.h b/Include/internal/pycore_debug_offsets.h
index 66f14e6..fbdc40a 100644
--- a/Include/internal/pycore_debug_offsets.h
+++ b/Include/internal/pycore_debug_offsets.h
@@ -41,7 +41,7 @@ extern "C" {
#define _GENERATE_DEBUG_SECTION_APPLE(name)
#endif
-#if defined(__linux__) && (defined(__GNUC__) || defined(__clang__))
+#if defined(__linux__) && (defined(__GNUC__) || defined(__clang__) || (_Py__has_attribute(section) && _Py__has_attribute(used)))
#define _GENERATE_DEBUG_SECTION_LINUX(name) \
__attribute__((section("." Py_STRINGIFY(name)))) \
__attribute__((used))
diff --git a/Objects/mimalloc/init.c b/Objects/mimalloc/init.c
index 81b2410..3856a10 100644
--- a/Objects/mimalloc/init.c
+++ b/Objects/mimalloc/init.c
@@ -676,7 +676,7 @@ static void mi_cdecl mi_process_done(void) {
}
static bool mi_initialized = _mi_process_init();
-#elif defined(__GNUC__) || defined(__clang__)
+#elif defined(__GNUC__) || defined(__clang__) || _Py__has_attribute(constructor)
// GCC,Clang: use the constructor attribute |
Member
|
Do you want to work on this PR, or may I take over? Does slimcc recognize
I don't think this bug is likely to hit CPython, so I'd prefer not working around it. |
Contributor
Author
Yes, it does! But the corresponding check of C23 style attributes should be
IMO
Please do! Thank you for taking care in this. |
|
This PR is stale because it has been open for 30 days with no activity. |
Member
@vstinner already did this in 9e5e1f9
I agree we should not add another IMHO this now just boils down to change Line 545 in d125f00 to #elif defined(__GNUC__) || defined(__clang__) || (defined(_MSC_VER) && _MSC_VER >= 1939)to gain back safety warnings on Windows in case of mismatching pointers: cpython/Include/cpython/object.h Lines 349 to 351 in d125f00 which is very wortwhile IMHO. |
Member
If Python is built with compiler A which supports @fuhsnn: Can you update your PR on the main branch and remove |
github-actions
Bot
removed
the
stale
Extend the _Py_TYPEOF macro to use __typeof__() with MSVC 17.9 and newer, or decltype() under C++11 and newer.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Member
|
I added Py_CLEAR() and Py_SETREF() tests in test_cppext with commit 36c7440. So this change should now be tested with C++. |
Member
|
I merged your updated (simpler) change, thanks! Sorry, it took a while to merge it. But better late than never ;-) IMO it's too late to backport this change to the 3.15 branch. I prefer to only change the main branch (Python 3.16) change to have enough time to test the change properly (starting with Python 3.16 alpha1 release, scheduled for 2026-10-13). |
|
|
|
Member
|
Oh, test_cppext fails on Windows:
Toolkit version: I suppose that |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the _Py_TYPEOF macro to more implementations of typeof and standardized equivalents on C23 and C++11. On MSVC, typeof is enabled through _MSC_VER check; for others, an autoconf probe is implemented.
_Py_TYPEOFon MSVC and other compilers supporting__typeof__#121647