gh-142197: Doc: Add missing import statement in importlib.metadata overview by Yashp002 · Pull Request #142208 · python/cpython

Yashp002 · 2025-12-03T06:28:45Z

Added missing from importlib.metadata import metadata import statement before the example code that uses metadata('wheel') in the overview section.

The documentation showed usage of the metadata() function without first importing it, causing a NameError when users tried to follow the example. This change ensures the example code is runnable as-is.

📚 Documentation preview 📚: https://cpython-previews--142208.org.readthedocs.build/

Issue: import.metadata overview missing import statement #142197

StanFromIreland

Please revert unrelated changes in different files.

StanFromIreland · 2025-12-03T16:59:48Z


 You can get the :ref:`metadata for a distribution <metadata>`::
-
-    >>> list(metadata('wheel'))  # doctest: +SKIP


Why are you changing the indentation?

bedevere-app · 2025-12-06T21:56:35Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Co-authored-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>

Yashp002 · 2025-12-10T11:40:59Z

I have made the requested changes; please review again.

bedevere-app · 2025-12-10T11:41:04Z

Thanks for making the requested changes!

@picnixz: please review the changes made to this pull request.

Yashp002 · 2025-12-24T17:47:14Z

@picnixz , just checking in, could you review my PR and let me know if there's anything more to fix?

.

picnixz · 2026-03-21T13:50:26Z

As I am on mobile I do not trust the GH UI so I will let another core dev merge this one

github-actions · 2026-05-03T00:29:45Z

This PR is stale because it has been open for 30 days with no activity.

github-actions · 2026-09-04T06:10:38Z

This PR is stale because it has been open for 90 days with no activity.

lubianat · 2026-09-10T19:45:29Z

@picnixz should this be merged? it is simple and perhaps done? (I guess the backport is pending; @Yashp002 ?)

picnixz · 2026-09-10T20:18:48Z

i forgot about it; backports are automatic once the PR is merged (and manual if fhere are conflicts). I am on mobile so I am going to merge this tomorrow, thanks for the reminder!

StanFromIreland · 2026-09-10T20:19:57Z

I can merge it right now @picnixz ?

picnixz · 2026-09-10T20:32:52Z

Yes please

miss-islington-app · 2026-09-10T20:40:08Z

Thanks @Yashp002 for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

bedevere-app · 2026-09-10T20:40:24Z

GH-157284 is a backport of this pull request to the 3.15 branch.

bedevere-app · 2026-09-10T20:40:29Z

GH-157285 is a backport of this pull request to the 3.14 branch.

bedevere-app · 2026-09-10T20:40:35Z

GH-157286 is a backport of this pull request to the 3.13 branch.

…data overview (GH-142208) (#157286) (cherry picked from commit f64ebfb) Co-authored-by: Yashraj <yashrajpala8@gmail.com> Co-authored-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

…data overview (GH-142208) (#157285) (cherry picked from commit f64ebfb) Co-authored-by: Yashraj <yashrajpala8@gmail.com> Co-authored-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Yashp002 requested review from jaraco and warsaw as code owners December 3, 2025 06:28

bedevere-app Bot added docs Documentation in the Doc dir skip news labels Dec 3, 2025

github-project-automation Bot added this to Docs PRs Dec 3, 2025

github-project-automation Bot moved this to Todo in Docs PRs Dec 3, 2025

bedevere-app Bot added the awaiting review label Dec 3, 2025

Yashp002 changed the title ~~Doc: Add missing import statement in importlib.metadata overview~~ gh-142197: Doc: Add missing import statement in importlib.metadata overview Dec 3, 2025

bedevere-app Bot mentioned this pull request Dec 3, 2025

import.metadata overview missing import statement #142197

Closed

StanFromIreland reviewed Dec 3, 2025

View reviewed changes

fixed unrelated changes

f41df32

Yashp002 force-pushed the metadata branch from 9915afe to f41df32 Compare December 3, 2025 08:00

StanFromIreland reviewed Dec 3, 2025

View reviewed changes

indent mistake

c40aff7

edgarrmondragon reviewed Dec 6, 2025

View reviewed changes

Comment thread Doc/library/importlib.metadata.rst Outdated

picnixz previously requested changes Dec 6, 2025

View reviewed changes

Comment thread Doc/library/importlib.metadata.rst

bedevere-app Bot added awaiting changes and removed awaiting review labels Dec 6, 2025

Yashp002 and others added 2 commits December 9, 2025 21:55

Update Doc/library/importlib.metadata.rst

94bdd04

Co-authored-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>

fixes

fb6cb82

bedevere-app Bot added awaiting change review and removed awaiting changes labels Dec 10, 2025

bedevere-app Bot requested a review from picnixz December 10, 2025 11:41

Merge branch 'main' into metadata

fe551eb

bedevere-app Bot removed the awaiting change review label Mar 21, 2026

picnixz disabled auto-merge March 21, 2026 13:49

picnixz enabled auto-merge (squash) March 21, 2026 13:49

picnixz disabled auto-merge March 21, 2026 13:50

picnixz added awaiting merge needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes and removed awaiting review labels Mar 21, 2026

github-actions Bot added the stale Stale PR or inactive for long period of time. label May 3, 2026

serhiy-storchaka added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 30, 2026

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jun 2, 2026

github-actions Bot added the stale Stale PR or inactive for long period of time. label Sep 4, 2026

StanFromIreland merged commit f64ebfb into python:main Sep 10, 2026
38 checks passed

github-project-automation Bot moved this from Todo to Done in Docs PRs Sep 10, 2026

bedevere-app Bot removed the awaiting merge label Sep 10, 2026

bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Sep 10, 2026

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Sep 10, 2026

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Sep 10, 2026


		You can get the :ref:`metadata for a distribution <metadata>`::

		>>> list(metadata('wheel')) # doctest: +SKIP

Uh oh!

Uh oh!

Conversation

Yashp002 commented Dec 3, 2025 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StanFromIreland left a comment

Choose a reason for hiding this comment

Uh oh!

StanFromIreland Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bedevere-app Bot commented Dec 6, 2025

Uh oh!

Yashp002 commented Dec 10, 2025

Uh oh!

bedevere-app Bot commented Dec 10, 2025

Uh oh!

Yashp002 commented Dec 24, 2025

Uh oh!

picnixz commented Mar 21, 2026

Uh oh!

github-actions Bot commented May 3, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

lubianat commented Sep 10, 2026

Uh oh!

picnixz commented Sep 10, 2026

Uh oh!

StanFromIreland commented Sep 10, 2026

Uh oh!

picnixz commented Sep 10, 2026

Uh oh!

Uh oh!

miss-islington-app Bot commented Sep 10, 2026

Uh oh!

bedevere-app Bot commented Sep 10, 2026

Uh oh!

bedevere-app Bot commented Sep 10, 2026

Uh oh!

bedevere-app Bot commented Sep 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Yashp002 commented Dec 3, 2025 •

edited by bedevere-app Bot

Loading