gh-154842: Reject repack() while a reading handle is open - #154843
Open
fedonman wants to merge 1 commit into
Open
gh-154842: Reject repack() while a reading handle is open#154843fedonman wants to merge 1 commit into
fedonman wants to merge 1 commit into
Conversation
ZipFile.repack() moves member data, but a ZipExtFile from an earlier open() keeps its own absolute position, so it silently returned data from the wrong place and a full read failed with a misleading CRC error. Raise ValueError while _fileRefCnt shows an open reading handle, as the writing-handle case already does.
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZipFile.repack()moves member data to lower offsets, but aZipExtFilefrom an earlieropen()keeps its own absolute position, so it silently returned data from the wrong placeand a full read failed with
BadZipFile: Bad CRC-32. RaiseValueErrorwhile an openreading handle exists, as the writing-handle case already does.
The test fails without the guard.
repack()is new in 3.16, so no NEWS entry.