gh-155074: Fix remaining-space calculation in _pyio.BufferedReader.readinto() - #155075
Open
yangbaechu wants to merge 1 commit into
Open
gh-155074: Fix remaining-space calculation in _pyio.BufferedReader.readinto()#155075yangbaechu wants to merge 1 commit into
_pyio.BufferedReader.readinto()#155075yangbaechu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #155074.
This PR fixes
_pyio.BufferedReader.readinto()when data from the internal buffer only partially fills the destination before a refill.The pure Python implementation limited each buffered copy by the destination's original length. After earlier bytes had been copied, this could make the next copy exceed the remaining memoryview slice and raise
ValueError. The copy is now limited by the remaining destination space,len(buf) - written.The regression test is shared by the C and pure Python implementations and verifies the returned byte count, destination contents, and unread data.
_pyio.BufferedReader.readinto()can raiseValueErrorafter partially filling the destination #155074