Skip to content

Fix a stray newline in the cell type docstring - #157240

Merged
StanFromIreland merged 1 commit into
python:mainfrom
DanielEScherzer:cell-class-docs
Sep 10, 2026
Merged

Fix a stray newline in the cell type docstring#157240
StanFromIreland merged 1 commit into
python:mainfrom
DanielEScherzer:cell-class-docs

Conversation

@DanielEScherzer

Copy link
Copy Markdown
Contributor

The contents documentation was split over multiple lines, but an extra newline meant that there was an (indented) line with just the word "and" followed by an unindented line with "further attempts...". Remove that newline to avoid having just a single word in the documentation and to fix the indentation.

The `contents` documentation was split over multiple lines, but an extra
newline meant that there was an (indented) line with just the word "and"
followed by an unindented line with "further attempts...". Remove that newline
to avoid having just a single word in the documentation and to fix the
indentation.
@python-cla-bot

python-cla-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app

bedevere-app Bot commented Sep 9, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@DanielEScherzer

DanielEScherzer commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

Not sure if this needs a test, but tested locally with

def outer_func(x):
    return lambda: print (x)
holds_cell = outer_func(5)
print(holds_cell.__closure__[0].__class__.__doc__)

Seemed trivial enough not to need a GitHub issue or a NEWS entry

@StanFromIreland StanFromIreland changed the title Cell: remove unneeded newline in the middle of class documentation Fix a stray newline in the cell type docstring Sep 10, 2026
@StanFromIreland
StanFromIreland merged commit 34439b8 into python:main Sep 10, 2026
61 checks passed
@StanFromIreland

Copy link
Copy Markdown
Member

Merged, thank you!

@StanFromIreland StanFromIreland added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Sep 10, 2026
@miss-islington-app

Copy link
Copy Markdown

Thanks @DanielEScherzer for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Thanks @DanielEScherzer for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Thanks @DanielEScherzer for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Sep 10, 2026

Copy link
Copy Markdown

GH-157276 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Sep 10, 2026
@bedevere-app

bedevere-app Bot commented Sep 10, 2026

Copy link
Copy Markdown

GH-157277 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Sep 10, 2026
@bedevere-app

bedevere-app Bot commented Sep 10, 2026

Copy link
Copy Markdown

GH-157278 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Sep 10, 2026
StanFromIreland pushed a commit that referenced this pull request Sep 10, 2026
…157277)

(cherry picked from commit 34439b8)

Co-authored-by: Daniel Scherzer <daniel.e.scherzer@gmail.com>
StanFromIreland pushed a commit that referenced this pull request Sep 10, 2026
…157276)

(cherry picked from commit 34439b8)

Co-authored-by: Daniel Scherzer <daniel.e.scherzer@gmail.com>
hugovk pushed a commit that referenced this pull request Sep 10, 2026
…157278)

Co-authored-by: Daniel Scherzer <daniel.e.scherzer@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Arch Linux Asan 3.13 (tierless) has failed when building commit 997d79d.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1464/builds/1255) and take a look at the build logs.
  4. Check if the failure is related to this commit (997d79d) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1464/builds/1255

Failed tests:

  • test_io

Failed subtests:

  • test_daemon_threads_shutdown_stderr_deadlock - test.test_io.CMiscIOTest.test_daemon_threads_shutdown_stderr_deadlock
  • test_daemon_threads_shutdown_stdout_deadlock - test.test_io.CMiscIOTest.test_daemon_threads_shutdown_stdout_deadlock

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/buildbot/buildarea/3.13.pablogsal-arch-x86_64.asan/build/Lib/test/test_io.py", line 4821, in test_daemon_threads_shutdown_stderr_deadlock
    self.check_daemon_threads_shutdown_deadlock('stderr')
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^
  File "/buildbot/buildarea/3.13.pablogsal-arch-x86_64.asan/build/Lib/test/test_io.py", line 4811, in check_daemon_threads_shutdown_deadlock
    self.assertFalse(err.strip('.!'))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
AssertionError: '=================================================================\n==1147610==ERROR: AddressSanitizer: heap-use-after-free on address 0x7ce84fc52898 at pc 0x55da58514306 bp 0x7bb84d9fe080 sp 0x7bb84d9fe070\nREAD of size 8 at 0x7ce84fc52898 thread T1\n' is not false


Traceback (most recent call last):
  File "/buildbot/buildarea/3.13.pablogsal-arch-x86_64.asan/build/Lib/test/test_io.py", line 4821, in test_daemon_threads_shutdown_stderr_deadlock
    self.check_daemon_threads_shutdown_deadlock('stderr')
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^
  File "/buildbot/buildarea/3.13.pablogsal-arch-x86_64.asan/build/Lib/test/test_io.py", line 4811, in check_daemon_threads_shutdown_deadlock
    self.assertFalse(err.strip('.!'))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
AssertionError: '=================================================================\n==1147741==ERROR: AddressSanitizer: heap-use-after-free on address 0x7c7356052898 at pc 0x560dd2402306 bp 0x7b4353dfe080 sp 0x7b4353dfe070\nREAD of size 8 at 0x7c7356052898 thread T1\n' is not false


Traceback (most recent call last):
  File "/buildbot/buildarea/3.13.pablogsal-arch-x86_64.asan/build/Lib/test/test_io.py", line 4816, in test_daemon_threads_shutdown_stdout_deadlock
    self.check_daemon_threads_shutdown_deadlock('stdout')
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^
  File "/buildbot/buildarea/3.13.pablogsal-arch-x86_64.asan/build/Lib/test/test_io.py", line 4811, in check_daemon_threads_shutdown_deadlock
    self.assertFalse(err.strip('.!'))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
AssertionError: '=================================================================\n==1147615==ERROR: AddressSanitizer: heap-use-after-free on address 0x7d1209a52898 at pc 0x5556b82d3306 bp 0x7be2077fe080 sp 0x7be2077fe070\nREAD of size 8 at 0x7d1209a52898 thread T1\n' is not false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants