Skip optimisations to speedup test_freeze rebuild - #157264
Draft
hugovk wants to merge 1 commit into
Draft
Conversation
Member
Author
|
!buildbot LTO PR |
|
🤖 New build scheduled with the buildbot fleet by @hugovk for commit fcecce3 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F157264%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Member
Author
|
Results look good:
The s390x buildbots are offline until the 15th due to migration from a Z15 to a Z17 machine, so will need to compare before and after on the new machine when it's ready. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For LTO buildbots,
test_toolsfromtest_freeze.pyaccounts for the majority of the test runtime:Often the rest of the test suite had finished running, and we're just hanging on for this one to finish.
This is because it involves rebuilding the interpreter, and this includes the LTO flags, which results in a slow rebuild. The rebuild is to test the freezing machinery, and optimisation flags aren't needed here.
See also #103053 which disabled the skipped the test on PGO, but not LTO. We could skip, but let's see if this improves things enough.