gh-156680 - Update IPv4Network and IPv6Network docstring. - #157280
Open
orsenthil wants to merge 3 commits into
Open
gh-156680 - Update IPv4Network and IPv6Network docstring.#157280orsenthil wants to merge 3 commits into
orsenthil wants to merge 3 commits into
Conversation
Mention that the address argument can be a two-tuple representing address description and a netmask.
|
|
||
| The address can also be a two-tuple of an address description | ||
| and a netmask, where the address description is either a | ||
| string, a 32-bits integer, a 4-bytes packed integer, or an |
Member
There was a problem hiding this comment.
Suggested change
| string, a 32-bits integer, a 4-bytes packed integer, or an | |
| string, a 32-bit integer, a 4-byte packed integer, or an |
I see this is inherited from the documentation, but this is grammatically incorrect currently.
Member
Author
There was a problem hiding this comment.
Yes. I wanted to stay consistent. Did a minor modification for readablity and removing rst specific syntax. Is there anything else?
Member
There was a problem hiding this comment.
Sorry, to clarify I suggest fixing this everywhere while we're here, if you don't mind?
Member
Author
There was a problem hiding this comment.
Sure, I will do that. Thanks for the quick review.
Member
Author
There was a problem hiding this comment.
Please take a look again.
Change to 32-bit integer and 4-byte packed integer. Co-authored-by: Stan Ulbrych <stan@python.org>
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mention that the address argument can be a two-tuple representing address description and a netmask.
It is a follow-up to this comment
#156681 (comment)
IPv6Network.next_network()raises the wrong error when addresses run out #156680