Skip to content

Fix set xor return types for abstract sets #16127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
subotac wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −2
Open

Fix set xor return types for abstract sets #16127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions stdlib/@tests/test_cases/builtins/check_set.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from collections.abc import Set as AbstractSet
from typing_extensions import Literal, assert_type


Expand Down Expand Up @@ -55,3 +56,10 @@ def test_frozenset_interface(s: frozenset[Literal["foo", "bar"]], y: frozenset[s
assert_type(s & y, frozenset[Literal["foo", "bar"]])
assert_type(s | y, frozenset[str])
assert_type(s ^ y, frozenset[str])


def test_xor_with_abstract_set(
s: set[Literal["foo", "bar"]], frozen: frozenset[Literal["foo", "bar"]], other: AbstractSet[str]
) -> None:
assert_type(s ^ other, AbstractSet[str])
assert_type(frozen ^ other, AbstractSet[str])
14 changes: 12 additions & 2 deletions stdlib/builtins.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1460,7 +1460,12 @@ class set(MutableSet[_T]):
def __ior__(self, value: AbstractSet[_T], /) -> Self: ... # type: ignore[override,misc]
def __sub__(self, value: AbstractSet[object], /) -> set[_T]: ...
def __isub__(self, value: AbstractSet[object], /) -> Self: ...
def __xor__(self, value: AbstractSet[_S], /) -> set[_T | _S]: ...

@overload
def __xor__(self, value: set[_S] | frozenset[_S], /) -> set[_T | _S]: ...
@overload
def __xor__(self, value: AbstractSet[_S], /) -> AbstractSet[_T | _S]: ...

def __ixor__(self, value: AbstractSet[_T], /) -> Self: ... # type: ignore[override,misc]
def __le__(self, value: AbstractSet[object], /) -> bool: ...
def __lt__(self, value: AbstractSet[object], /) -> bool: ...
Expand Down Expand Up @@ -1491,7 +1496,12 @@ class frozenset(AbstractSet[_T_co]):
def __and__(self, value: AbstractSet[object], /) -> frozenset[_T_co]: ...
def __or__(self, value: AbstractSet[_S], /) -> frozenset[_T_co | _S]: ...
def __sub__(self, value: AbstractSet[object], /) -> frozenset[_T_co]: ...
def __xor__(self, value: AbstractSet[_S], /) -> frozenset[_T_co | _S]: ...

@overload
def __xor__(self, value: set[_S] | frozenset[_S], /) -> frozenset[_T_co | _S]: ...
@overload
def __xor__(self, value: AbstractSet[_S], /) -> AbstractSet[_T_co | _S]: ...

def __le__(self, value: AbstractSet[object], /) -> bool: ...
def __lt__(self, value: AbstractSet[object], /) -> bool: ...
def __ge__(self, value: AbstractSet[object], /) -> bool: ...
Expand Down