Skip to content

WIden parameter type accepted by zipfile.is_zipfile and tarfile.is_tarfile #16385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonathandung wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −4
Open

WIden parameter type accepted by zipfile.is_zipfile and tarfile.is_tarfile #16385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
739c234
Update is_zipfile parameter type to FileDescriptorOrPath
jonathandung Sep 11, 2026
d91fd15
Update is_tarfile parameter type to FileDescriptorOrPath
jonathandung Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stdlib/tarfile.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import bz2
import io
import sys
from _typeshed import ReadableBuffer, StrOrBytesPath, StrPath, SupportsRead, WriteableBuffer
from _typeshed import FileDescriptorOrPath, ReadableBuffer, StrOrBytesPath, StrPath, SupportsRead, WriteableBuffer
from builtins import list as _list # aliases to avoid name clashes with fields named "type" or "list"
from collections.abc import Callable, Iterable, Iterator, Mapping
from gzip import _ReadableFileobj as _GzipReadableFileobj, _WritableFileobj as _GzipWritableFileobj
Expand Down Expand Up @@ -732,7 +732,7 @@ class TarFile:

open = TarFile.open

def is_tarfile(name: StrOrBytesPath | IO[bytes]) -> bool: ...
def is_tarfile(name: FileDescriptorOrPath | IO[bytes]) -> bool: ...

class TarError(Exception): ...
class ReadError(TarError): ...
Expand Down
4 changes: 2 additions & 2 deletions stdlib/zipfile/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import io
import sys
from _typeshed import SizedBuffer, StrOrBytesPath, StrPath
from _typeshed import FileDescriptorOrPath, SizedBuffer, StrPath
from collections.abc import Callable, Iterable, Iterator
from io import TextIOWrapper
from os import PathLike
Expand Down Expand Up @@ -389,7 +389,7 @@ else:
def joinpath(self, *other: StrPath) -> Path: ...
def __truediv__(self, add: StrPath) -> Path: ...

def is_zipfile(filename: StrOrBytesPath | _SupportsReadSeekTell) -> bool: ...
def is_zipfile(filename: FileDescriptorOrPath | _SupportsReadSeekTell) -> bool: ...

ZIP64_LIMIT: Final[int]
ZIP_FILECOUNT_LIMIT: Final[int]
Expand Down