Add section about metaclass constructors - #2326
Closed
Viicos wants to merge 2 commits into
Closed
Conversation
Viicos
commented
Jul 31, 2026
Comment on lines
+670
to
+674
| Regardless of the evaluated return type of the implied metaclass call, a | ||
| :keyword:`class` statement defines a class, and type checkers should evaluate the | ||
| type of the bound name accordingly (``type[MyClass1]`` in the example above). | ||
| The implied metaclass call is evaluated only for the purpose of validating | ||
| its arguments. |
Contributor
Author
There was a problem hiding this comment.
This doesn't represent the runtime behavior:
class Meta(type):
def __new__(cls, *args, **kwargs):
return 1
class Class(metaclass=Meta): ...
Class
#> 1But all type checkers currently model this. It is pretty unusual for something like this to happen, and type checkers may rely on the assumption that a class statements always results in a type object.
Viicos
commented
Jul 31, 2026
| class MyClass4(other=1): # Type error: MyClass4.__init_subclass__() takes no keyword arguments | ||
| pass | ||
|
|
||
| A metaclass :meth:`!__init__` method has no effect on this rule: when the |
Contributor
Author
There was a problem hiding this comment.
Perhaps type checkers could also enforce consistency between __init_subclass__() and __new__()/__init__() in some way?
Contributor
Author
|
Apologies, I keep facing a Github bug opening PRs on the upstream repo. Meant to open this on my fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.