tests: skip TestPythonRuntimeAliasedIO on TensorRT-RTX with the C++ runtime - #4541
Closed
tp5uiuc wants to merge 1 commit into
Closed
tests: skip TestPythonRuntimeAliasedIO on TensorRT-RTX with the C++ runtime#4541tp5uiuc wants to merge 1 commit into
tp5uiuc wants to merge 1 commit into
Conversation
…untime The runtimes are expected to be either/or: the flavor is picked from whether libtorchtrt.so is loaded, and every in-library TRTEngine construction site is gated on that same flag. TestPythonRuntimeAliasedIO hand-builds a python TRTEngine from packed engine info regardless, so on a TensorRT-RTX build that also ships the C++ runtime it produces a combination the library never does: a torchbind-backed RuntimeCache asked to serve a python engine. ensure_cache() returns None there and set_runtime_cache rejects an explicitly-passed None, so the two tests in the class fail. Skip that combination rather than teach the cache plumbing to serve it. The guard is deliberately narrow: on standard TensorRT the runtime-config path is short-circuited in ensure_initialized, so a hand-built engine is harmless and the class stays live; it also stays live on python-only builds, where the python TRTEngine is the real runtime and the test is the point.
Collaborator
Author
|
[by Claude Code] Closing in favour of #4482, which fixes these tests rather than skipping them.
Verified on TensorRT-RTX/A100, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What
Skip
TestPythonRuntimeAliasedIOon TensorRT-RTX builds that also ship the C++runtime, where it currently fails.
Why
The runtimes are expected to be either/or: the flavor is picked from whether
libtorchtrt.sois loaded, and every in-libraryTRTEngineconstruction site isgated on that same flag. This class hand-builds a Python
TRTEnginefrom packedengine info regardless, producing a combination the library never does — a
torchbind-backed
RuntimeCacheasked to serve a Python engine.ensure_cache()returns
Nonethere andset_runtime_cacherejects an explicitly-passedNone,so both tests in the class fail.
How
test_aliased_io.py:skipIf(torch_tensorrt_runtime and tensorrt_rtx).Deliberately narrow — on standard TensorRT the runtime-config path is
short-circuited in
ensure_initialized, so a hand-built engine is harmless andthe class stays live; it also stays live on python-only builds, where the
Python
TRTEngineis the real runtime and the test is the point.Testing
tests/py/dynamo/runtime/The same suite on
mainreports 2 failed.Type of change
Checklist: