fix(dynamo): normalize scalar values at engine boundaries - #4628
Open
narendasan wants to merge 1 commit into
Open
fix(dynamo): normalize scalar values at engine boundaries#4628narendasan wants to merge 1 commit into
narendasan wants to merge 1 commit into
Conversation
Materialize scalar partition inputs as zero-dimensional CUDA tensors before calling the Tensor[] execute_engine schema, and restore scalar engine outputs with aten.item for their original consumers. The meta kernel now skips scalar input metadata and selects output placement from the first tensor input. Fixes #4614 Fixes #4616 Fixes #4617 Fixes #4620 Tests: - pytest tests/py/dynamo/models/test_exporter_inlining.py -n0 (7 passed) - pytest tests/py/dynamo/models/test_meta_kernel_shape_inference.py -n0 (12 passed) - original issue reproductions for #4614, #4616, #4617, and #4620 - #4620 AOTInductor package creation succeeded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issues
Closes #4614
Closes #4616
Closes #4617
Closes #4620
Tests
Stack
2 of 7. Base: #4627. Follow-up: narendasan/fix-device-placement.