feature: Dynamo implementation of torch_executed_modules - #4639
Open
dongwoonhyun wants to merge 2 commits into
Open
feature: Dynamo implementation of torch_executed_modules#4639dongwoonhyun wants to merge 2 commits into
dongwoonhyun wants to merge 2 commits into
Conversation
Usage is consistent with the TorchScript version (matching by fully-qualified class name). The implementation checks each node's `nn_module_stack` metadata to see if it or any parent module matches.
The fast and global partitioners are tested to make sure they produce 2, 1, or 0 TRT engines depending on torch_executed_modules. An extra test is added for the None behavior fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implementation of
torch_executed_modulesfor the dynamo path. The usage is consistent with the TorchScript version (matching by fully-qualified class name). The actual implementation walks throughnode.meta.get("nn_module_stack")and excludes the node if its or any of its parents' modules are intorch_executed_modules.Also added tests to the fast and global partitioners that exercise the feature.
Type of change
Checklist: