Short-circuit index_put with a statically-empty index - #4641
Open
apbose wants to merge 1 commit into
Open
Conversation
An empty index means no positions to scatter into, so index_put is a no-op. Building the scatter path anyway (reshaping an index tensor to a shape containing a 0) trips a TensorRT-internal squeezeDims assertion at build time on DGX Spark (GB10, SM 12.1) -- Error Code 2, "Assertion inputDims != nullptr failed" in validationUtils.cpp. Other platforms don't hit it, but the operation is a no-op regardless of platform, so avoid building it at all.
github-actions
Bot
added
component: conversion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An empty index means no positions to scatter into, so index_put is a no-op. Building the scatter path anyway (reshaping an index tensor to a shape containing a 0) trips a TensorRT-internal squeezeDims assertion at build time on DGX Spark (GB10, SM 12.1) -- Error Code 2, "Assertion inputDims != nullptr failed" in validationUtils.cpp. Other platforms don't hit it (verified: passes on H100/A100/GB200-family/ORIN_IGX), but the operation is a no-op regardless of platform, so avoid building it at all.
Related but distinct from #4621 (dynamic-index broadcast bug in the same converter) -- different trigger condition, different TRT error, different fix location.
Type of change
Checklist: