Skip to content

Codegen: Support empty selected operator sets - #21548

Open
Erik-Lundell wants to merge 1 commit into
pytorch:mainfrom
Erik-Lundell:upstream-empty-op-sets
Open

Codegen: Support empty selected operator sets#21548
Erik-Lundell wants to merge 1 commit into
pytorch:mainfrom
Erik-Lundell:upstream-empty-op-sets

Conversation

@Erik-Lundell

@Erik-Lundell Erik-Lundell commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Ensure generated registration sources still include the required function header when there are no selected kernels. Also keep empty selected operator YAML compatible with torchgen by emitting an empty et_kernel_metadata map instead of null.

Tested with two tests:

  • Codegen a library where the selected ops don't match the kernel library, causing silent dropping of those selected ops.
  • Codegen a library with no selected ops.

The intention is to avoid having to generate the
selected operator yaml at configure time to decide whether to generate and include the lib, simplifying cmake logic.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

Ensure generated registration sources still include the
required function header when there are no selected kernels.
Also keep empty selected operator YAML compatible with
torchgen by emitting an empty et_kernel_metadata map
instead of null.

Tested with two tests:
- Codegen a library where the selected
ops don't match the kernel library, causing silent dropping
of those selected ops.
- Codegen a library with no selected ops.

The intention is to avoid having to generate the
selected operator yaml at configure time to decide
whether to generate and include the lib, simplifying
cmake logic.

Signed-off-by: Erik Lundell <erik.lundell@arm.com>
Change-Id: Ib190161ac76232aa6264fdef53bd7c2d18b45f85
@pytorch-bot

pytorch-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21548

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 15 Unclassified Failures

As of commit 971d0b7 with merge base adaaa8b (image):

NEW FAILURES - The following jobs have failed:

  • pull / unittest-buck / macos / macos-job (gh)
    ##[error]API rate limit exceeded for installation. If you reach out to GitHub Support for help, please include the request ID E64B:42C37:1EC04B:6B7221:6A70B537 and timestamp 2026-08-03 15:35:19 UTC. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) - https://docs.github.com/en/rest/using-the-rest-api/getting-started-with-the-rest-api#rate-limiting
  • pull / unittest-editable / macos / macos-job (gh)
    ##[error]API rate limit exceeded for installation. If you reach out to GitHub Support for help, please include the request ID F715:255A6A:21C1C1:756EEC:6A70B53E and timestamp 2026-08-03 15:35:27 UTC. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) - https://docs.github.com/en/rest/using-the-rest-api/getting-started-with-the-rest-api#rate-limiting
  • trunk / test-llama-runner-mac (fp32, mps) / macos-job (gh)
    ##[error]API rate limit exceeded for installation. If you reach out to GitHub Support for help, please include the request ID F66E:382373:1B71BC:5BC4F7:6A70C48B and timestamp 2026-08-03 16:40:43 UTC. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) - https://docs.github.com/en/rest/using-the-rest-api/getting-started-with-the-rest-api#rate-limiting

UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:

  • pull / test-coreml-bc-macos (macos-m1-stable) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]API rate limit exceeded for installation. If you reach out to GitHub Support for help, please include the request ID D1FA:30047:88358C:1D61245:6A70C4D1 and timestamp 2026-08-03 16:41:53 UTC. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) - https://docs.github.com/en/rest/using-the-rest-api/getting-started-with-the-rest-api#rate-limiting
  • trunk / test-models-macos-coreml (edsr) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]API rate limit exceeded for installation. If you reach out to GitHub Support for help, please include the request ID EBBA:17F01A:187504:5201EE:6A70C484 and timestamp 2026-08-03 16:40:36 UTC. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) - https://docs.github.com/en/rest/using-the-rest-api/getting-started-with-the-rest-api#rate-limiting
  • trunk / test-models-macos-coreml (emformer_join) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]API rate limit exceeded for installation. If you reach out to GitHub Support for help, please include the request ID F890:37B676:9AC88D:2144B75:6A70C4C3 and timestamp 2026-08-03 16:41:39 UTC. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) - https://docs.github.com/en/rest/using-the-rest-api/getting-started-with-the-rest-api#rate-limiting
  • trunk / test-models-macos-coreml (resnet50) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]API rate limit exceeded for installation. If you reach out to GitHub Support for help, please include the request ID E917:FD9F:82F1F2:1C4F2FE:6A70C4BB and timestamp 2026-08-03 16:41:31 UTC. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) - https://docs.github.com/en/rest/using-the-rest-api/getting-started-with-the-rest-api#rate-limiting
  • trunk / test-models-macos-coreml (w2l) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]API rate limit exceeded for installation. If you reach out to GitHub Support for help, please include the request ID DBAB:3E6385:1E545B:645978:6A70C4A5 and timestamp 2026-08-03 16:41:09 UTC. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) - https://docs.github.com/en/rest/using-the-rest-api/getting-started-with-the-rest-api#rate-limiting
  • trunk / test-models-macos-cpu (efficient_sam, portable) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]API rate limit exceeded for installation. If you reach out to GitHub Support for help, please include the request ID EDC4:2CF20C:3B82:CA16:6A70C49B and timestamp 2026-08-03 16:40:59 UTC. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) - https://docs.github.com/en/rest/using-the-rest-api/getting-started-with-the-rest-api#rate-limiting
  • trunk / test-models-macos-cpu (emformer_join, xnnpack-quantization-delegation) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]API rate limit exceeded for installation. If you reach out to GitHub Support for help, please include the request ID DBF9:F97BE:1CF7F:61634:6A70C422 and timestamp 2026-08-03 16:38:58 UTC. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) - https://docs.github.com/en/rest/using-the-rest-api/getting-started-with-the-rest-api#rate-limiting
  • trunk / test-models-macos-cpu (llama, portable) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]API rate limit exceeded for installation. If you reach out to GitHub Support for help, please include the request ID C6BA:3F5BD0:8EF6:1E5F0:6A70C48E and timestamp 2026-08-03 16:40:46 UTC. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) - https://docs.github.com/en/rest/using-the-rest-api/getting-started-with-the-rest-api#rate-limiting
  • trunk / test-models-macos-cpu (llama2, xnnpack-quantization-delegation) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]API rate limit exceeded for installation. If you reach out to GitHub Support for help, please include the request ID E0A9:2314EE:1AD5A9:5A1784:6A70C43F and timestamp 2026-08-03 16:39:28 UTC. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) - https://docs.github.com/en/rest/using-the-rest-api/getting-started-with-the-rest-api#rate-limiting
  • trunk / test-models-macos-cpu (mobilebert, xnnpack-quantization-delegation) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]API rate limit exceeded for installation. If you reach out to GitHub Support for help, please include the request ID DBE9:3F5BD0:81B8:1B8BB:6A70C48B and timestamp 2026-08-03 16:40:43 UTC. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) - https://docs.github.com/en/rest/using-the-rest-api/getting-started-with-the-rest-api#rate-limiting
  • trunk / test-models-macos-cpu (resnet50, xnnpack-quantization-delegation) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]API rate limit exceeded for installation. If you reach out to GitHub Support for help, please include the request ID E432:79F21:9163A5:1F51760:6A70C43C and timestamp 2026-08-03 16:39:24 UTC. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) - https://docs.github.com/en/rest/using-the-rest-api/getting-started-with-the-rest-api#rate-limiting
  • trunk / test-models-macos-cpu (vit, xnnpack-quantization-delegation) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]API rate limit exceeded for installation. If you reach out to GitHub Support for help, please include the request ID CCC8:E563D:DAFA:2E249:6A70C454 and timestamp 2026-08-03 16:39:48 UTC. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) - https://docs.github.com/en/rest/using-the-rest-api/getting-started-with-the-rest-api#rate-limiting
  • trunk / test-models-macos-cpu (w2l, xnnpack-quantization-delegation) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]API rate limit exceeded for installation. If you reach out to GitHub Support for help, please include the request ID CB1D:37B676:99DFED:2113A75:6A70C4A1 and timestamp 2026-08-03 16:41:06 UTC. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) - https://docs.github.com/en/rest/using-the-rest-api/getting-started-with-the-rest-api#rate-limiting
  • trunk / test-models-macos-mps / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]API rate limit exceeded for installation. If you reach out to GitHub Support for help, please include the request ID EF0B:E563D:40F7:DDC9:6A70C43A and timestamp 2026-08-03 16:39:23 UTC. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) - https://docs.github.com/en/rest/using-the-rest-api/getting-started-with-the-rest-api#rate-limiting
  • trunk / test-selective-build-macos (cmake) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]API rate limit exceeded for installation. If you reach out to GitHub Support for help, please include the request ID C9BC:3DC872:ADC3FF:25AEDF7:6A70C40C and timestamp 2026-08-03 16:38:36 UTC. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) - https://docs.github.com/en/rest/using-the-rest-api/getting-started-with-the-rest-api#rate-limiting

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 3, 2026
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant