Skip to content

MovePermuteAfterConcat made generic reorder pass (#21557) - #21557

Open
DrJessop wants to merge 1 commit into
pytorch:mainfrom
DrJessop:export-D114628981
Open

MovePermuteAfterConcat made generic reorder pass (#21557)#21557
DrJessop wants to merge 1 commit into
pytorch:mainfrom
DrJessop:export-D114628981

Conversation

@DrJessop

@DrJessop DrJessop commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Summary:

There is a common pattern in which we permute all inputs to a cat in the same way. Instead of permuting all inputs, we can instead cat first and then permute the output.

Reviewed By: aliafzal

Differential Revision: D114628981

@pytorch-bot

pytorch-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21557

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 922124f with merge base e8feb9e (image):

NEW FAILURES - The following jobs have failed:

  • pull / unittest-buck / macos / macos-job (gh)
    ##[error]API rate limit exceeded for installation. If you reach out to GitHub Support for help, please include the request ID C7F2:237671:2AA8F3F:8E8EB74:6A7119C7 and timestamp 2026-08-03 22:44:23 UTC. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) - https://docs.github.com/en/rest/using-the-rest-api/getting-started-with-the-rest-api#rate-limiting
  • pull / unittest-editable / macos / macos-job (gh)
    ##[error]API rate limit exceeded for installation. If you reach out to GitHub Support for help, please include the request ID C28F:148A9B:A4B1DC:227ADFA:6A7119BE and timestamp 2026-08-03 22:44:14 UTC. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) - https://docs.github.com/en/rest/using-the-rest-api/getting-started-with-the-rest-api#rate-limiting

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 3, 2026
@meta-codesync

meta-codesync Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114628981.

@meta-codesync meta-codesync Bot changed the title MovePermuteAfterConcat made generic reorder pass MovePermuteAfterConcat made generic reorder pass (#21557) Aug 3, 2026
DrJessop added a commit to DrJessop/executorch that referenced this pull request Aug 3, 2026
Summary:

There is a common pattern in which we permute all inputs to a cat in the same way. Instead of permuting all inputs, we can instead cat first and then permute the output.

Differential Revision: D114628981
@DrJessop
DrJessop force-pushed the export-D114628981 branch from 4e52bf5 to 76297df Compare August 3, 2026 19:22
DrJessop added a commit to DrJessop/executorch that referenced this pull request Aug 3, 2026
Summary:

There is a common pattern in which we permute all inputs to a cat in the same way. Instead of permuting all inputs, we can instead cat first and then permute the output.

Reviewed By: aliafzal

Differential Revision: D114628981
@DrJessop
DrJessop force-pushed the export-D114628981 branch from 76297df to 63d30a7 Compare August 3, 2026 20:02
Summary:

There is a common pattern in which we permute all inputs to a cat in the same way. Instead of permuting all inputs, we can instead cat first and then permute the output.

Reviewed By: aliafzal

Differential Revision: D114628981
@DrJessop
DrJessop force-pushed the export-D114628981 branch from 63d30a7 to 922124f Compare August 3, 2026 20:03
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants