Skip to content

Isolate CI-sensitive warnings-as-errors pins - #21558

Open
Murf-o wants to merge 1 commit into
pytorch:mainfrom
Murf-o:export-D114599890
Open

Isolate CI-sensitive warnings-as-errors pins#21558
Murf-o wants to merge 1 commit into
pytorch:mainfrom
Murf-o:export-D114599890

Conversation

@Murf-o

@Murf-o Murf-o commented Aug 3, 2026

Copy link
Copy Markdown

Summary:

Context

Enabling repo-wide warnings-as-errors under Kotlin 2.2 requires explicitly pinning un-migrated Android targets to the current off behavior before flipping the default.

This Diff

Isolates warning pins that trigger specialized CI or export workflows from the bulk landable stack: mirrored ExecuTorch Android targets, IG Direct/MSYS targets, Oculus targets, and AR/VR schema/library targets. Keeping these changes at the stack tip allows their GitHub export and runtime integration suites to be handled independently without blocking the remaining mechanical migration diffs.

drop-conflicts

Differential Revision: D114599890

Summary:
# Context
Enabling repo-wide warnings-as-errors under Kotlin 2.2 requires explicitly pinning un-migrated Android targets to the current off behavior before flipping the default.

# This Diff
Isolates warning pins that trigger specialized CI or export workflows from the bulk landable stack: mirrored ExecuTorch Android targets, IG Direct/MSYS targets, Oculus targets, and AR/VR schema/library targets. Keeping these changes at the stack tip allows their GitHub export and runtime integration suites to be handled independently without blocking the remaining mechanical migration diffs.

drop-conflicts

Differential Revision: D114599890
@pytorch-bot

pytorch-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21558

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 Awaiting Approval, 2 New Failures

As of commit 732c20d with merge base 7af1a4c (image):

AWAITING APPROVAL - The following workflows need approval before CI can run:

NEW FAILURES - The following jobs have failed:

  • Cadence Build & Test / hifi-build / hifi4 (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
  • Cadence Build & Test / vision-build / vision (gh)
    ##[error]Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla

Copy link
Copy Markdown

CLA Missing ID

  • ❌ The email address for the commit (732c20d) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please visit our EasyCLA portal and chat with our support bot.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 3, 2026
@meta-codesync

meta-codesync Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@Murf-o has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114599890.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant