Fix Interpolator return type being a generator - #132
Open
djhoese wants to merge 1 commit into
Open
Conversation
Also clarify language around kx_/ky_ arguments which are flipped from typical geotiepoints convention. Normally x is columns (cross-track) and y is rows (along-track), but `RectBivariateSpline` was provided coordinates in the (y, x) order so the `kx_` argument is rows/along-track and `ky_` is columns/cross-track.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
=======================================
Coverage 89.04% 89.04%
=======================================
Files 20 20
Lines 1515 1515
=======================================
Hits 1349 1349
Misses 166 166
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
coverage: 88.176%. remained the same — djhoese:bugfix-interpolator-cleanup into pytroll:main |
Member
Author
|
@mraspaud Claude says you're basically the sole author of all of this stuff so I think that means you have to review it. |
Member
|
I remember I've pair-programmed with Adam 10+ years ago on parallellizing something, but I think that's it. Looks like something Martin needs to check anyway, so I'll remove myself from reviewers. |
pnuu
removed their request for review
September 8, 2026 13:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also clarify language around kx_/ky_ arguments which are flipped from typical geotiepoints convention. Normally x is columns (cross-track) and y is rows (along-track), but
RectBivariateSplinewas provided coordinates in the (y, x) order so thekx_argument is rows/along-track andky_is columns/cross-track.Written by Claude with a lot of feedback from me.
@pnuu I never remember if you're part of geotiepoints development. Let me know and feel free to remove yourself from the reviewers.
git diff origin/main **/*py | flake8 --diff