Skip to content

visitor.py LOC cleanup - #348

Open
micpap25 wants to merge 4 commits into
qBraid:mainfrom
micpap25:visitor-cleanup
Open

visitor.py LOC cleanup#348
micpap25 wants to merge 4 commits into
qBraid:mainfrom
micpap25:visitor-cleanup

Conversation

@micpap25

@micpap25 micpap25 commented Aug 5, 2026

Copy link
Copy Markdown

Summary of changes

Start on #188
First commit fixes some typos and starts a validation function; long-term goal is to aggregate more of the validation process into helper functions.

Still needs tests!

@micpap25
micpap25 requested a review from TheGupta2012 as a code owner August 5, 2026 04:24
@argus-eye

argus-eye Bot commented Aug 5, 2026

Copy link
Copy Markdown

Argus review

Auto-review is off for this repo. Tick the box below to run a review on this PR.

  • Trigger Argus review

Estimated cost

  • Files changed: 2
  • Diff lines (±): 47
  • Historical avg: ~318.9k tokens · ~$1.35 · across last 6 review(s)

Tip: you can also comment @argus-eye review at any time.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 102fcb11-d723-456a-b565-ec97c50b99a2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

👋 Hey there! It looks like the changelog might need an update.

Please take a moment to edit the CHANGELOG.md with:

  • A brief, one-to-two sentence summary of your changes.
  • A link back to this PR for reference.
  • (Optional) A small working example if you've added new features.

Comment thread src/pyqasm/visitor.py Outdated
Comment thread src/pyqasm/visitor.py
Comment thread src/pyqasm/visitor.py Outdated

@TheGupta2012 TheGupta2012 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @micpap25 for working on this! Can you please resolve the comments and continue the work for refactoring the visitor? This seems like a good start!

Function is simple but has unintuitive logic; the "return None" approach used here should be removed if we decide not to use this refactoring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants