Show removed keys in colored view when a dict becomes empty - #621
Open
koushik777-ML wants to merge 1 commit into
Open
Show removed keys in colored view when a dict becomes empty#621koushik777-ML wants to merge 1 commit into
koushik777-ML wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
While investigating issue #575, I found a related edge case in ColoredView when a dictionary becomes empty after keys are removed.
In this case, the colored view could return before the removed-key handling was processed, resulting in the removed keys not being displayed correctly.
The original list/empty-list behavior reported in #575 is already fixed on the current dev branch, so this PR addresses the related dictionary case.
Changes
Fix the early-return behavior in ColoredView
Ensure removed dictionary keys are shown when the dictionary becomes empty
Add regression tests covering the edge case
Testing
Added regression tests for the dictionary case
Full test suite: 1277 passed, 44 skipped