fix(project): reconcile canonical autosave authority truth - #801
Conversation
The production web/PWA autosave, lifecycle flush, and manual-save paths now use the canonical IndexedDB authority, but the authority module header and migration ledger still described that integration as future work. That stale wording could make the release and native-readiness evidence contradict the shipped persistence boundary. Update both truth records to identify the shared autosave persistence seam, preserve the deliberate Tauri/filesystem boundary, and retain the remaining universal-ingress, filesystem-writer, Rust-Core, and authority-switch gates as incomplete. No runtime behavior, fallback policy, migration behavior, or production authority is changed. Validation: - pnpm run signing:doctor - pnpm run hooks:install - pnpm run docs:check - pnpm run pr:budget -- --base origin/main --prospective - git diff --check
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: qnbs/WorldScript-Studio/.coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe PR updates documentation for web/PWA canonical persistence routing and Tauri filesystem-first routing. It records the non-canonical IndexedDB fallback conditions and remaining migration work. ChangesPersistence routing documentation
Priority: ⬇️ Low Comment |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis metadata-only correction updates project migration documentation and module comments to accurately record that web/PWA autosave, lifecycle flush, and manual-save flows now route through the generation-fenced canonical IndexedDB authority, while Tauri/filesystem persistence and other integration paths remain unfinished. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
The repository CHANGELOG Reference Guard requires the actual GitHub PR number in the Unreleased note, which was unavailable until draft PR #801 was created. This bootstrap correction intentionally changes CHANGELOG.md only. It records the already-completed #553 truth-sync documentation fix and does not alter source, tests, workflows, or governance behavior. Validation: - git diff --check - pnpm run pr:budget -- --base origin/main --prospective - staged path: CHANGELOG.md only
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
qnbs
changed the title
🤖 CodeAnt AI — Review Status
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
codeant-ai
Bot
added
the
size:S
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6688184e59
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: qnbs/WorldScript-Studio/.coderabbit.yaml
Review profile: CHILL
Plan: Essentials
Run ID: 69dd019f-b8a2-445a-b870-5b0f9f87768b
📒 Files selected for processing (3)
CHANGELOG.mddocs/native/CORE-MIGRATION-LEDGER.mdservices/storage/idbProjectCanonicalAuthority.ts
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.
The canonical IDB authority documentation incorrectly described the Tauri path as filesystem-only, although storageService can retain its existing IndexedDB backend when filesystem initialization or legacy-key cleanup fails. Qualify the module header and the #553 migration ledger to distinguish the normal Tauri filesystem writer from that non-canonical dbService fallback. Add the required single QNBS-v3 persistence/native-boundary rationale comment. Runtime routing, authority selection, fallback behavior, and canonical writer semantics are intentionally unchanged. The desktop fallback remains outside the generation-fenced canonical writer until an admitted equivalent filesystem writer exists. Validation:\n- pnpm run docs:check\n- git diff --check\n- PR_BUDGET_BASE=origin/main pnpm run pr:budget -- --base origin/main --prospective
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8cc3234900
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The #553 release note still described the Tauri persistence boundary as unconditional filesystem-only, although storageService retains its existing non-canonical IndexedDB backend when filesystem initialization or legacy-key cleanup fails. Qualify that single release-note sentence so the changelog matches the module header and migration ledger. This is metadata-only: runtime routing, authority selection, fallback behavior, and canonical writer semantics remain unchanged. Validation:\n- PR_BUDGET_BASE=origin/main pnpm run pr:budget -- --base origin/main --prospective\n- pnpm run docs:check\n- git diff --cached --check
There was a problem hiding this comment.
Gates Passed
See analysis details in CodeScene
Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
1 participant
Summary
Reconcile the #553 persistence truth records with the implementation already shipped on
main.services/projectAutosavePersistence.ts.docs/native/CORE-MIGRATION-LEDGER.mdto mark that web/PWA integration as complete while keeping the Tauri/filesystem writer, remaining universal ingress/egress, Rust Core authority, and R-15 transition gates explicitly incomplete.Scope boundaries
This PR changes documentation and truth records only. It does not change runtime behavior, persistence semantics, migration behavior, fallback/dual-write policy, Tauri authority, Rust Core authority, Qt readiness, or R-15 admission.
Validation
pnpm run signing:doctorpnpm run hooks:installpnpm run docs:checkPR_BUDGET_BASE=origin/main pnpm run ci:prepush— PASS,DOCS_ONLYgit diff --checkSummary by Sourcery
Align persistence documentation and truth records with the canonical autosave authority currently used in production.
Enhancements:
Documentation:
Summary by CodeRabbit