Fix(wasi): enable configurable stack overflow protection - #1700
Open
aayush-kapoor wants to merge 1 commit into
Open
Fix(wasi): enable configurable stack overflow protection#1700aayush-kapoor wants to merge 1 commit into
aayush-kapoor wants to merge 1 commit into
Conversation
Author
|
@bnoordhuis could i please bother you for a review? facing a downstream issue 🙏 |
2 tasks
TooTallNate
added a commit
to vercel-labs/quickjs-wasi
that referenced
this pull request
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR makes
JS_SetMaxStackSize()work on WASI builds.WASI still defaults to no stack guard, so existing users are unaffected. Embedders can now opt into a limit and receive a catchable JavaScript stack overflow instead of a WASM memory trap.
It also adds WASI tests covering:
Why
The Run SDK wants to use
quickjs-wasi. the Run SDK currently supports a configurablemaxStackSizeByteslimit. That limit currently cannot be enforced because QuickJS ignoresJS_SetMaxStackSize()on WASI.This change unblocks stack-limit support in
quickjs-wasi, which can then be used byrunRelated
runPRs: