Say when to bump the pinned anchor-v2-testing revision - #134
Open
mikemaccana wants to merge 1 commit into
Open
Conversation
The comment explained why `anchor-v2-testing` is pinned but named nothing that should cause it to change, unlike the `--no-idl` workaround beside it which points at anchor#4947 as its removal trigger. Someone reading this in six months had no way to tell whether the rev was still the right one. Now it says: bump deliberately rather than automatically, because `anchor-next` is the v2 development branch and a later revision can carry breakage as easily as fixes; and when `anchor-v2-testing` reaches crates.io, the git source goes away entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment beside the pinned
anchor-v2-testingrevision explained why it is pinned but named nothing that should ever cause it to change. The--no-idlworkaround a few lines away points atanchor#4947as its removal trigger; this one pointed at nothing, so a reader six months from now had no way to tell whether the revision was still the right one, or what would make it wrong.The added lines say:
Applied to all 56 manifests carrying the dependency. Comments only: no dependency, version or code changes, so nothing to verify beyond CI.
Two details behind the wording, in case they are worth arguing with:
"deliberately, never automatically" rather than "keep it current".
anchor-nextis the active v2 development branch, not a release branch. A newer revision is not automatically a better one, and this repository has no signal that would catch a regression in it beyond CI going red."drop the git source" is the real end state. The pin exists only because crates.io has no
anchor-v2-testing. Once it is published, none of this applies and an ordinary version requirement replaces the whole block.Generated by Claude Code