[WIP] Gate indexer readiness on control plane - #6669
Draft
Mallets wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_connectivity/endpointsmethods so readiness uses the same endpoint-availability signal as metastore clients./health/readyz503 after control-plane shutdown while metastore remains ready.generate_extra_service_methodsimplicationscheck_connectivity()andendpoints()helpers toControlPlaneServiceclients and implementations; it does not add protobuf RPCs or change wire compatibility.BalanceChannelcontains at least one discovered endpoint. This is an endpoint-availability check, not an end-to-end RPC health probe.ControlPlaneServiceimplementation must implement them.Test plan
cargo check -p quickwit-protocargo check -p quickwit-servecargo test -p quickwit-serve test_readiness_updates --libcargo test -p quickwit-integration-tests test_indexer_readiness_decreases_after_control_plane_shutdowncargo clippy -p quickwit-serve -p quickwit-integration-tests --all-features --testsmake fmt