Skip to content

fix(storage): initialize OpenDAL's default HTTP transport - #6678

Merged
guilload merged 1 commit into
mainfrom
david-yaffe/fix-opendal-default-http-transport
Aug 11, 2026
Merged

fix(storage): initialize OpenDAL's default HTTP transport#6678
guilload merged 1 commit into
mainfrom
david-yaffe/fix-opendal-default-http-transport

Conversation

@dayaffe

@dayaffe dayaffe commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Description

OpenDAL 0.58 moved HTTP handling behind a process-wide transport. Quickwit disables OpenDAL's default features, including auto-register-services, so the migration in #6656 left normal GCS operators with a lazy default transport but no installed implementation. The first GCS request therefore failed with ConfigInvalid: default HTTP transport is not installed.

This PR:

  • Calls opendal::install_default() at the shared GCS constructor so the compiled Reqwest transport is registered as OpenDAL's process-wide default before the first GCS request
  • Replaces the deprecated reqwest-rustls-tls alias with the canonical http-transport-reqwest feature. Both select the same Reqwest/Rustls transport in OpenDAL 0.58 but reqwest-rustls-tls will be deleted in 0.59

How was this PR tested?

This issue was discovered while following the local development instructions in CONTRIBUTING.md and running make test-all. Before the fix, the GCS integration test consistently failed with ConfigInvalid: default HTTP transport is not installed.

After the fix:

  • The GCS integration test passed both in isolation and as part of the
    full suite.
  • make test-all passed 3,030 tests with 17 skipped; the 10 failpoint
    tests also passed.
  • The Clippy, nightly rustfmt, and license-header checks passed.

Closes #6677

OpenDAL 0.58 no longer auto-installs the Reqwest transport when default features are disabled, causing GCS requests to fail before
reaching the backend. Use the canonical transport feature and initialize the default explicitly.

Closes #6677
@dayaffe
dayaffe requested a review from a team as a code owner August 11, 2026 16:00
@pront
pront requested a review from guilload August 11, 2026 16:23
@guilload

Copy link
Copy Markdown
Member

@dayaffe, we gotta fix CI so PRs such as #6656 can't be merged anymore. The "coverage" workflow runs on main on merge but:

  • it is currently broken
  • when it wasn't broken, nobody cared and acted on the job failing.

Can you look into a solution?

@guilload
guilload merged commit b3248be into main Aug 11, 2026
9 checks passed
@guilload
guilload deleted the david-yaffe/fix-opendal-default-http-transport branch August 11, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GCS requests fail after OpenDAL 0.58 upgrade

2 participants