Fix ReDoS in stripHtml - #308
Open
y0d4a wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stripHtml()can exhibit quadratic runtime on malformed HTML containing repeated unterminated tags.The current regex may repeatedly scan the remaining input while searching for a closing
>, allowing crafted RSS/Atom content to block the Node.js event loop.This change prevents tag matching from crossing another
<, bounding each attempted match and avoiding the pathological repeated scanning behavior.A regression test was added using ~160 KB of repeated unterminated
<brsequences.Benchmark on Node.js v22.16.0 with the same 160 KB input:
The patch is intentionally minimal and does not add dependencies.