Skip to content

fix: ignore generated Umi files during lint - #730

Merged
zombieJ merged 1 commit into
masterfrom
fix/ignore-umi-eslint
Sep 11, 2026
Merged

fix: ignore generated Umi files during lint#730
zombieJ merged 1 commit into
masterfrom
fix/ignore-umi-eslint

Conversation

@zombieJ

@zombieJ zombieJ commented Sep 11, 2026

Copy link
Copy Markdown
Member

Summary

  • ignore nested Umi generated files in the ESLint flat config
  • prevent compile checks from linting generated Dumi output

Validation

  • npm run compile
  • npm run lint

Summary by CodeRabbit

  • 代码质量
    • 调整代码检查范围,避免检查特定构建生成目录中的文件。

@vercel

vercel Bot commented Sep 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
upload Ready Ready Preview Sep 11, 2026 2:46am UTC

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 747549f8-fe62-48ca-bcd6-e39fe46f2357

📥 Commits

Reviewing files that changed from the base of the PR and between 6fd7fb3 and cb7b449.

📒 Files selected for processing (1)
  • eslint.config.mjs

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


Walkthrough

ESLint 忽略列表新增了 '**/.umi/'。ESLint 不再检查 Umi 构建产物目录中的文件。

Changes

ESLint 配置更新

Layer / File(s) Summary
忽略 Umi 构建目录
eslint.config.mjs
ignores 数组中新增 '**/.umi/'

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to cb7b4

This change prevents generated Umi files from being linted and is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题准确描述了主要变更:让 ESLint 忽略生成的 Umi 文件。标题简洁、清晰,并与代码改动和 PR 目标一致。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ignore-umi-eslint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

小兔挥爪改配置
Umi 目录藏起来
ESLint 轻轻绕过
构建文件不再吵
代码检查更清爽

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit cb7b449.

@github-actions

github-actions Bot commented Sep 11, 2026

Copy link
Copy Markdown

❌ Deploy failed

PR preview ❌ Failed ❌ Failed
🔗 Preview https://react-component-upload-preview-pr-730.surge.sh (may be unavailable)
📝 Commitcb7b449
🪵 LogsView logs
📋 Build log (last lines)
npm error
npm error Could not resolve dependency:
npm error peer eslint@"^3 || ^4 || ^5 || ^6 || ^7 || ^8 || ^9.7" from eslint-plugin-react@7.37.5
npm error node_modules/eslint-plugin-react
npm error   dev eslint-plugin-react@"^7.37.5" from the root project
npm error   eslint-plugin-react@"^7.32.2" from @umijs/fabric@4.0.1
npm error   node_modules/@umijs/fabric
npm error     @umijs/fabric@"^4.0.0" from rc-test@7.1.3
npm error     node_modules/rc-test
npm error       dev rc-test@"^7.1.3" from the root project
npm error
npm error Conflicting peer dependency: eslint@9.39.5
npm error node_modules/eslint
npm error   peer eslint@"^3 || ^4 || ^5 || ^6 || ^7 || ^8 || ^9.7" from eslint-plugin-react@7.37.5
npm error   node_modules/eslint-plugin-react
npm error     dev eslint-plugin-react@"^7.37.5" from the root project
npm error     eslint-plugin-react@"^7.32.2" from @umijs/fabric@4.0.1
npm error     node_modules/@umijs/fabric
npm error       @umijs/fabric@"^4.0.0" from rc-test@7.1.3
npm error       node_modules/rc-test
npm error         dev rc-test@"^7.1.3" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /home/runner/.npm/_logs/2026-09-11T02_48_25_261Z-eresolve-report.txt
npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2026-09-11T02_48_25_261Z-debug-0.log

🤖 Powered by surge-preview

@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.76%. Comparing base (6fd7fb3) to head (cb7b449).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #730   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files           6        6           
  Lines         328      328           
  Branches       92       96    +4     
=======================================
  Hits          301      301           
  Misses         27       27           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zombieJ
zombieJ merged commit 6eeddf4 into master Sep 11, 2026
14 checks passed
@zombieJ
zombieJ deleted the fix/ignore-umi-eslint branch September 11, 2026 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant