Skip to content

fix: probing for forms that mount after the content script runs #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Woodstock-IL-Cameras wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: probing for forms that mount after the content script runs #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions src/content.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,37 @@ import {
postWebpageMessage,
} from './services/webpage';

const PROBE_INTERVAL_MS = 1000;

postWebpageMessage('INIT');
addWebpageMessageListener((message) => {
postExtensionMessage(message);
});

// A form can mount long after this script runs — inside a dialog, or on a client-side route —
// and the page only announces itself in reply to an INIT. Probing just once therefore misses
// every form that did not already exist, so keep asking while the tab is in the foreground.
// https://github.com/react-hook-form/devtools-extension/issues/15
let probeInterval: number | undefined;

const startProbing = () => {
if (probeInterval === undefined) {
probeInterval = window.setInterval(
() => postWebpageMessage('INIT'),
PROBE_INTERVAL_MS,
);
}
};

const stopProbing = () => {
window.clearInterval(probeInterval);
probeInterval = undefined;
};

document.addEventListener('visibilitychange', () =>
document.hidden ? stopProbing() : startProbing(),
);

if (!document.hidden) {
startProbing();
}