fix(windows): preserve SQLite strings and roll back failed commits - #1336
Open
OskarEichler wants to merge 1 commit into
Open
fix(windows): preserve SQLite strings and roll back failed commits#1336OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: d8dbb6e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use explicit SQLite string lengths, handle empty batches and retain transaction ownership until COMMIT succeeds.
Compatibility / observable behavior
Embedded-NUL strings are no longer truncated; empty reads/removals return empty/success instead of asserting; failed commits roll back. No schema change. This does not migrate values already truncated by prior writes.
Related to #1331. This is a focused part of a source review; it does not claim the entire repository is bug-free.
Test Plan
yarn build:js,yarn test:ts(6 tasks),yarn test:lint(6 tasks),yarn test:formatandgit diff --checkpass on the combined review checkout.testAndroidHostTest,macosArm64TestandiosSimulatorArm64Testpass with Java 21. The first Android run used Java 17 and failed Robolectric's SDK 36/JDK check; rerunning with the project's documented JDK fixed the environment failure without a source workaround.