Skip to content

fix(mock): clear held storage instances when resetting #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krizzu merged 1 commit into from
Aug 31, 2026
+13 −2
Merged

fix(mock): clear held storage instances when resetting #1339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/review-mock-reset.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@react-native-async-storage/async-storage": patch
---

Clear existing mock stores before resetting the registry and preserve the default legacy instance's registry identity.

9 changes: 7 additions & 2 deletions packages/async-storage/src/jest/AsyncStorageMock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class AsyncStorageMemoryImpl implements AsyncStorage {
};
}

const inMemoryDbRegistry = new Map<string, AsyncStorageMemoryImpl>();
const inMemoryDbRegistry = new Map<string, AsyncStorage>();

export function createAsyncStorage(databaseName: string): AsyncStorage {
if (!inMemoryDbRegistry.has(databaseName)) {
Expand All @@ -53,7 +53,12 @@ export function createAsyncStorage(databaseName: string): AsyncStorage {
}

export function clearAllMockStorages(): void {
for (const storage of inMemoryDbRegistry.values()) {
void storage.clear();
}
inMemoryDbRegistry.clear();
inMemoryDbRegistry.set("legacy", legacyStorage);
}

export default createAsyncStorage("legacy");
const legacyStorage = createAsyncStorage("legacy");
export default legacyStorage;
Loading