Add prepared-text-layout screenshot coverage for wrapped Text - #58414
Open
Abbondanzo wants to merge 2 commits into
Open
Add prepared-text-layout screenshot coverage for wrapped Text#58414Abbondanzo wants to merge 2 commits into
Abbondanzo wants to merge 2 commits into
Conversation
Summary: Add `textWidthMode="longest-line"` to size wrapped `Text` to its widest rendered line on Android and iOS. This keeps content-proportional spacing in horizontal layouts without an `onTextLayout` round trip; the default measurement behavior is unchanged. Changelog: [General][Added] - Add `textWidthMode="longest-line"` for sizing wrapped `Text` to its widest rendered line. Differential Revision: D118718410
Summary: Add screenshot coverage for the RNTester `textWidthMode` example and run it against both text measurement paths: the default one, and the one behind the `enablePreparedTextLayout` runtime gate, which measures paragraphs through a separate code path in `TextLayoutManager`. RNTester now applies a feature flag override before React Native starts, so a test harness can select which variant the app boots with. Changelog: [Internal] - Add RNTester screenshot coverage for `textWidthMode` under both text layout paths Differential Revision: D119212680
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119212680. |
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add screenshot coverage for the RNTester
textWidthModeexample and run itagainst both text measurement paths: the default one, and the one behind the
enablePreparedTextLayoutruntime gate, which measures paragraphs through aseparate code path in
TextLayoutManager.RNTester now applies a feature flag override before React Native starts, so a
test harness can select which variant the app boots with.
Changelog:
[Internal] - Add RNTester screenshot coverage for
textWidthModeunder both text layout pathsDifferential Revision: D119212680