Remove Fabric and TurboModule dead config (#58434) - #58434
Open
christophpurrer wants to merge 2 commits into
Open
Remove Fabric and TurboModule dead config (#58434)#58434christophpurrer wants to merge 2 commits into
christophpurrer wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119380472. |
) Summary: TurboModules, Fabric and bridgeless are all unconditionally enabled in the New Architecture, so every remaining flag on `DefaultNewArchitectureEntryPoint` was dead configuration. Reduce it to the one thing it still selects: the release level. Removes the deprecated parameterized `load(...)` overloads, the `fabricEnabled`, `turboModulesEnabled` and `concurrentReactEnabled` getters, and `isConfigurationValid`. Call sites that passed `fabricEnabled` to `DefaultReactActivityDelegate` now use its two-argument constructor, which already ignored the flag. Changelog: [Android][Breaking] - Remove the deprecated `DefaultNewArchitectureEntryPoint.load(turboModulesEnabled, fabricEnabled)` overloads; use `load()` instead [Android][Breaking] - Remove `DefaultNewArchitectureEntryPoint.fabricEnabled`, `turboModulesEnabled`, `concurrentReactEnabled` and `isConfigurationValid` Differential Revision: D119370657
Summary: Follow-up to D116318829, addressing rubennorte's review comment. Fabric and TurboModules shipped before bridgeless and are always on, so the toggles for them were hardcoded and read nowhere. Android, `DefaultNewArchitectureEntryPoint` — now only selects the release channel and loads the SO: - removed `fabricEnabled`, `turboModulesEnabled`, `concurrentReactEnabled` - removed the deprecated `load(turboModulesEnabled)` and `load(turboModulesEnabled, fabricEnabled)` overloads - removed `isConfigurationValid`, and with it `DefaultNewArchitectureEntryPointTest` (every test targeted it) - updated the 8 in-repo call sites that passed `fabricEnabled` into the deprecated 3-arg `DefaultReactActivityDelegate` constructor, which discarded it iOS: - removed `fabricEnabled` / `turboModuleEnabled` from `RCTRootViewFactoryConfiguration` - removed the corresponding `RCTDefaultReactNativeFactoryDelegate` stubs and the `RCTAppDelegate.h` doc references `ReactAndroid.api` and the `ReactApple*Cxx.api` snapshots are regenerated. One call site is not updated here: `users/zh/zhaogang/benchmarks/SimpleRN/android/app/src/main/java/com/simplern/MainActivity.kt` still imports `DefaultNewArchitectureEntryPoint.fabricEnabled`. It is a personal benchmark app under `users/` that is not materialized in this working copy, so it could not be edited. Changelog: [General][Breaking] - Remove the `fabricEnabled` / `turboModulesEnabled` / `concurrentReactEnabled` accessors and remaining deprecated `load` overloads from `DefaultNewArchitectureEntryPoint`, and the `fabricEnabled` / `turboModuleEnabled` properties from `RCTRootViewFactoryConfiguration`; Fabric and TurboModules are always enabled https://www.internalfb.com/agent-home?session_id=dmh-2bfbb113-43fc-4bc4-819d-874c5101a1c8 Differential Revision: D119380472
meta-codesync
Bot
changed the title
christophpurrer
force-pushed
the
export-D119380472
branch
from
September 10, 2026 22:55
699dea8 to
c9a2108
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Follow-up to D116318829, addressing rubennorte's review comment. Fabric and TurboModules shipped before bridgeless and are always on, so the toggles for them were hardcoded and read nowhere.
Android,
DefaultNewArchitectureEntryPoint— now only selects the release channel and loads the SO:fabricEnabled,turboModulesEnabled,concurrentReactEnabledload(turboModulesEnabled)andload(turboModulesEnabled, fabricEnabled)overloadsisConfigurationValid, and with itDefaultNewArchitectureEntryPointTest(every test targeted it)fabricEnabledinto the deprecated 3-argDefaultReactActivityDelegateconstructor, which discarded itiOS:
fabricEnabled/turboModuleEnabledfromRCTRootViewFactoryConfigurationRCTDefaultReactNativeFactoryDelegatestubs and theRCTAppDelegate.hdoc referencesReactAndroid.apiand theReactApple*Cxx.apisnapshots are regenerated.One call site is not updated here:
users/zh/zhaogang/benchmarks/SimpleRN/android/app/src/main/java/com/simplern/MainActivity.ktstill importsDefaultNewArchitectureEntryPoint.fabricEnabled. It is a personal benchmark app underusers/that is not materialized in this working copy, so it could not be edited.Changelog:
[General][Breaking] - Remove the
fabricEnabled/turboModulesEnabled/concurrentReactEnabledaccessors and remaining deprecatedloadoverloads fromDefaultNewArchitectureEntryPoint, and thefabricEnabled/turboModuleEnabledproperties fromRCTRootViewFactoryConfiguration; Fabric and TurboModules are always enabledhttps://www.internalfb.com/agent-home?session_id=dmh-2bfbb113-43fc-4bc4-819d-874c5101a1c8
Differential Revision: D119380472