Fix StaticCallOnNonStaticToInstanceCallRector for same-class calls - #7876
Merged
TomasVotruba merged 1 commit intoFeb 3, 2026
Merged
Conversation
When calling a non-static method statically from within the same class, convert to $this->method() instead of skipping. This eliminates the PHP deprecation warning for non-static method called statically. Calls to ancestor methods (e.g., Grandpa::method() from a descendant) are still skipped as they are valid non-static usage.
Member
|
Looks good to me, thank you |
nikspyratos
added a commit
to nikspyratos/rector-src
that referenced
this pull request
Jun 5, 2026
…c scope StaticCallOnNonStaticToInstanceCallRector rewrites a same-class static call `SameClass::nonStaticMethod()` to `$this->nonStaticMethod()` without checking whether the enclosing function-like is `static`. Inside a static method, static closure or static arrow function there is no `$this`, so the generated code fatals at runtime with "Using $this when not in object context". The same-class `$this->` branch was widened in rectorphp#7876 (fixing rectorphp/rector#9613) so that same-class static calls always convert, but it lacks a static-scope guard. This is the bug reported in rectorphp/rector#9647. Guard the same-class branch with `$scope->hasVariableType('this')->yes()`, which PHPStan resolves correctly for static methods, static closures and static arrow functions (including those nested inside non-static scopes). When `$this` is not available the rule now skips instead of producing invalid code; instance-scope behavior from rectorphp#7876 is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The StaticCallOnNonStaticToInstanceCallRector rule was skipping the case where the static call was to a method that was implemented in the same class or a superclass. But it should actually only skip if it is a superclass. For the same class, it makes more sense to convert the call to a method call to the current instance.
Fixes rectorphp/rector#9613