[Caching] Deprecate cacheMetaExtension(), report warning when used - #8251
Conversation
Niche mechanism. Rector handles cache on its own; custom invalidation is better handled in CI in a generic way, e.g. by clearing the cache directory. The config option is kept and marked @deprecated, it only reports a warning. The mechanism itself is no longer applied.
adb1717 to
3e69749
Compare
|
Hi Tomas, by luck I stumbled upon this PR that removes my work from #7933. Of course I'm a bit sad to see this but it's your call after all which I respect. I see you don't see a need for cache extensions. Would you be open for allowing configuring a custom FileComputeHasher? Then I could just override the hash method with my custom logic. Moving this cache busting responsibility to the CI as suggested in this PR is not really an option for when using it locally. |
|
Hey, sorry to hear that. I'm trying to make Rector more and more simpler and cutting niche features. Saying that, won't accept any such feature: I'd be open to those benefiting most users and general Rector speed. |
The
cacheMetaExtension()is a niche mechanism. Let Rector handle its cache on its own; if custom invalidation is needed, CI can handle it in a more generic way, e.g. by clearing the cache directory.The config option stays and is marked
@deprecated; it only reports a warning now. The mechanism itself is no longer applied, so there is no BC layer to keep alive.What is deprecated
RectorConfig::cacheMetaExtension()RectorConfigBuilder::withCacheMetaExtension()CacheMetaExtensionInterfaceWarning on use
Docs removal: https://github.com/rectorphp/getrector-com/pull/new/remove-cache-meta-extension-docs