Add generics to AbstractRector, RectorInterface and ConfigurableRectorInterface

[mspirkov]

I’m developing an extension for Rector and I’ve come across some PHPStan errors:

I propose solving this as follows:

1. Add generics to AbstractRector, RectorInterface, and ConfigurableRectorInterface.
2. Specify the return type as list for getNodeTypes, since it is essentially always list.

This will also make the code more concise and clear, in my opinion.

[mspirkov]

I see that rector-laravel also has this error, but it’s simply ignored: https://github.com/driftingly/rector-laravel/blob/2636a2af80ecb35fff8dd1e5d67ff939becb2673/phpstan.neon#L23

[TomasVotruba]

Seems too many changes and some of them disabling IDE autocomplete.

Any easier way to automate this?

[mspirkov]

Seems too many changes

I can add generics to AbstractRector, RectorInterface, and ConfigurableRectorInterface and leave the rest unchanged. This will solve the problem for those who use the maximum PHPStan level, and it won’t cause any inconvenience for others (they’ll be able to continue using @param annotations). Would this option work for you?

some of them disabling IDE autocomplete

Everything works well in VS Code.

Any easier way to automate this?

Unlikely. Generics are usually used in such cases.

[TomasVotruba]

It breaks PHPStorm autocomplete, as types are gone. I prefer the ignore as Laravel does rather than duplicate same types in docblock and remove type support in IDEs (apart VS Code).

[mspirkov]

And if I do this using @phpstan annotations and leave all the existing PHPDoc annotations untouched?

[mspirkov]

Then this would allow me not to ignore PHPStan errors, and I wouldn’t have to write extra annotations everywhere (it would be enough to simply use @extends)