[Testing] Isolate ApplicationFileProcessorTest cache dir to fix parallel flake - #8360
Merged
TomasVotruba merged 1 commit intoAug 22, 2026
Merged
Conversation
TomasVotruba
deleted the
fix-application-file-processor-cache-isolation
branch
August 22, 2026 11:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ApplicationFileProcessorTestasserts that files are cached as unchanged on disk, using the shared default cache dirsys_get_temp_dir()/rector_cached_files.Cacheis a process-wide singleton and that dir is shared across every parallelfastunit -tiachunk process.Other tests wipe that whole dir mid-run:
ChangedFilesDetector::clear()in teardown (rm -rfthe dir),When a parallel process wipes the dir between this test's
processFiles()and its assertion,hasFileChanged()defensively returnstrue, so theassertFalse(...)calls flip:It is a latent flake. It surfaced in #8358 because that PR touches the central
ConfigurationRuleFilter, so TIA marked this test impacted and co-scheduled it with cache-wiping tests.mainwas green only by scheduling luck.Fix
Isolate this test's cache dir, mirroring the existing
_rector_cached_files_testpattern used by the caching tests. The container is reset insetUp()(same pattern asSkipperRectorRuleTest) so the isolated dir is applied before theCachesingleton is built.Proof
Background loop wiping the default dir while running the test 8x: