[DI] Register PHPStan PhpVersionFactory as public service so 3rd-party rules can autowire it - #8365
Merged
Merged
Conversation
…y rules can autowire it The entropy container autowires by reflection and throws on non-class scalar constructor params (?int $versionId, ?string $composerPhpVersion) of PHPStan\Php\PhpVersionFactory, which illuminate/container previously resolved as null. 3rd-party rules such as drupal-rector's FunctionalTestDefaultThemePropertyRector inject this service directly and broke with 'Cannot resolve parameter "versionId"'. Serve it from the PHPStan container like ReflectionProvider.
Member
|
For note: https://github.com/rectorphp/rector-src/actions/runs/32719470879/job/97407608005?pr=8365 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.