feat(v2): AAP seed EE - #76
Conversation
Signed-off-by: Andrew Block <andy.block@gmail.com>
GitHub Actions
Failure
| aap_seed_token: "{{ aap_token | default(omit) }}" | ||
| aap_seed_validate_certs: "{{ aap_validate_certs | default(true) }}" | ||
| aap_seed_secure_logging: true | ||
| aap_seed_secure_logging: "{{ secure_logging | default(true) }}" |
There was a problem hiding this comment.
I saw this "global" collection variable on the last PR I reviewed. I don't believe there is any "standard" way to capture/flag/name collection level variables, but I think we should make a standard for ourselves. Reason being, if we pick a standard early they are easy to find and add to the ansible lint config to verify as a valid variable name. Since role variables are always prefixed with the role name, I would suggest the same standard be applied to the collection name. They don't need to have the whole collection name, just something unique that won't collide with other collections or roles. So my suggestion would be the prefix 'ovm_'.
There was a problem hiding this comment.
This isn't a blocking suggestion as I realize it would require extensive changes to existing code. Just something to consider before we get too far into the process.
| aap_seed_git_ssh_key: "{{ aap_git_ssh_key | default('') }}" | ||
| aap_seed_git_ssh_key_unlock: "{{ aap_git_ssh_key_unlock | default('') }}" | ||
|
|
||
| aap_seed_execution_environment_description: "{{ aap_execution_environment_description | default(omit, true) }}" |
There was a problem hiding this comment.
I think you may be better off setting the default to an empty string rather than omitting it. Setting a variable value with the omit can get messy later if it gets called. Omit populates the variable with a bunch of garbage data.
There was a problem hiding this comment.
I recommend putting the default(omit) in the actual task module and you wont have that issue
| host: "{{ aap_seed_execution_environment_credential_host }}" | ||
| password: "{{ aap_seed_execution_environment_credential_password }}" | ||
| username: "{{ aap_seed_execution_environment_credential_username }}" | ||
| verify_ssl: {{ aap_seed_execution_environment_credential_verify_ssl | default(true) | bool }} No newline at end of file |
There was a problem hiding this comment.
aap_seed_execution_environment_credential_verify_ssl is neither in defaults or the argument specs
3 participants
Description
Adds support in the
aap_seedrole to define an Execution Environment and associated credentialType of Change